Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Enable on-demand clusters based on groups extra properties (⚠️ devops) #4738

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 12, 2023

What do these changes do?

  • based on groups extra properties, asks director-v2 to run in on-demand clusters mode
  • pass ENV variables to clusters-keeper
  • return ETA of cluster in the logs passed to the frontend
  • log rabbit message now contains optional node id
  • ENVs are set in the .env-devel file

Related issue/s

How to test

DevOps Checklist

new ENV variables to be defined

CLUSTERS_KEEPER_MAX_MISSED_HEARTBEATS_BEFORE_CLUSTER_TERMINATION=5
CLUSTERS_KEEPER_TASK_INTERVAL=60

the following ENV are only necessary in case clusters-keeper is enabled:

CLUSTERS_KEEPER_EC2_ACCESS_KEY_ID=XXXXXXXXXX
CLUSTERS_KEEPER_EC2_ENDPOINT=ec2.amazonaws.com
CLUSTERS_KEEPER_EC2_INSTANCES_ALLOWED_TYPES="[\"g4dn.xlarge\"]"
CLUSTERS_KEEPER_EC2_INSTANCES_AMI_ID=XXXXXXXXXXX
CLUSTERS_KEEPER_EC2_INSTANCES_KEY_NAME=XXXXXXXXXXXXXX
CLUSTERS_KEEPER_EC2_INSTANCES_SECURITY_GROUP_IDS="[\"XXXXXXXXXXXXX\"]"
CLUSTERS_KEEPER_EC2_INSTANCES_SUBNET_ID=XXXXXXXXXXXXX
CLUSTERS_KEEPER_EC2_REGION_NAME=us-east-1
CLUSTERS_KEEPER_EC2_SECRET_ACCESS_KEY=XXXXXXXXXXXXX

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Sep 12, 2023
@sanderegg sanderegg added this to the the nameless milestone Sep 12, 2023
@sanderegg sanderegg self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4738 (31f0212) into master (ab5fa9a) will increase coverage by 1.9%.
The diff coverage is 82.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4738      +/-   ##
=========================================
+ Coverage    86.8%   88.7%    +1.9%     
=========================================
  Files        1112     509     -603     
  Lines       46198   26330   -19868     
  Branches     1013     190     -823     
=========================================
- Hits        40107   23376   -16731     
+ Misses       5864    2907    -2957     
+ Partials      227      47     -180     
Flag Coverage Δ
integrationtests 65.2% <76.4%> (+1.4%) ⬆️
unittests 86.9% <82.3%> (+2.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...imcore_service_director_v2/utils/comp_scheduler.py 100.0% <ø> (ø)
...ore_service_director_v2/modules/clusters_keeper.py 56.0% <50.0%> (+3.6%) ⬆️
...-v2/src/simcore_service_director_v2/core/errors.py 77.9% <100.0%> (ø)
...rector_v2/modules/comp_scheduler/base_scheduler.py 90.9% <100.0%> (+<0.1%) ⬆️
.../src/simcore_service_director_v2/utils/rabbitmq.py 100.0% <100.0%> (ø)
...simcore_service_webserver/director_v2/_handlers.py 95.6% <100.0%> (+1.9%) ⬆️

... and 624 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/connect-groups-extra-properties branch from 8143c67 to 93e3f03 Compare September 12, 2023 15:30
@sanderegg sanderegg marked this pull request as ready for review September 12, 2023 15:30
@sanderegg sanderegg force-pushed the comp-backend/connect-groups-extra-properties branch from 93e3f03 to c54faed Compare September 13, 2023 05:26
@sanderegg sanderegg force-pushed the comp-backend/connect-groups-extra-properties branch from c54faed to 9ac8e43 Compare September 13, 2023 08:32
@sanderegg sanderegg changed the title ✨Enable on-demand clusters based on groups extra properties ✨Enable on-demand clusters based on groups extra properties (⚠️ devops) Sep 13, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 13, 2023

Code Climate has analyzed commit 31f0212 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 0394294 into ITISFoundation:master Sep 13, 2023
@sanderegg sanderegg deleted the comp-backend/connect-groups-extra-properties branch September 13, 2023 10:06
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants