-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️On-demand clusters: remove dask-gateway #4760
♻️On-demand clusters: remove dask-gateway #4760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4760 +/- ##
========================================
+ Coverage 86.8% 87.0% +0.2%
========================================
Files 1115 1138 +23
Lines 46511 47509 +998
Branches 1021 1021
========================================
+ Hits 40392 41356 +964
- Misses 5888 5922 +34
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f52ef39
to
52502fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the "unfancy" banner ;-) ... just some minor comments
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/dask.py
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/dask.py
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/dask.py
Outdated
Show resolved
Hide resolved
3017449
to
b4030b6
Compare
cbd482d
to
6a43354
Compare
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit 6a43354 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
Clusters-keeper
osparc-computational-cluster-manager-{app_settings.SWARM_STACK_NAME}-user_id:{user_id}-wallet_id:{wallet_id}
dask-sidecar
/home/scu/.config/dask/distributed.yml
was not writabledirector-v2
Related issue/s
How to test
DevOps Checklist