Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Ensure the progress is set to None #4783

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Sep 21, 2023
@sanderegg sanderegg added this to the the nameless milestone Sep 21, 2023
@sanderegg sanderegg self-assigned this Sep 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2023

Code Climate has analyzed commit 094cecc and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4783 (094cecc) into master (0fb7103) will decrease coverage by 18.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4783      +/-   ##
=========================================
- Coverage    86.5%   68.4%   -18.1%     
=========================================
  Files        1150     490     -660     
  Lines       47887   25242   -22645     
  Branches     1023     190     -833     
=========================================
- Hits        41428   17290   -24138     
- Misses       6227    7905    +1678     
+ Partials      232      47     -185     
Flag Coverage Δ
integrationtests 65.0% <ø> (+12.6%) ⬆️
unittests 84.6% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._director_v2/modules/db/repositories/comp_tasks.py 96.6% <ø> (ø)

... and 914 files with indirect coverage changes

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg merged commit 1d1c5d6 into ITISFoundation:master Sep 21, 2023
@sanderegg sanderegg deleted the bugfig/progress-not-set-correctly branch September 21, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants