Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Propagate products to entire backend #4961

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Oct 31, 2023

What do these changes do?

  • Propagate products in API-server to all backend (apparently only webserver and catalog use the products)

Related issue/s

How to test

DevOps Checklist

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4961 (5c6e6c8) into master (e41af2e) will decrease coverage by 21.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4961      +/-   ##
=========================================
- Coverage    87.1%   65.2%   -21.9%     
=========================================
  Files        1124     583     -541     
  Lines       47320   28662   -18658     
  Branches      976     195     -781     
=========================================
- Hits        41223   18702   -22521     
- Misses       5879    9911    +4032     
+ Partials      218      49     -169     
Flag Coverage Δ
integrationtests 63.6% <ø> (-1.5%) ⬇️
unittests 82.4% <100.0%> (-2.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...service_api_server/api/dependencies/application.py 100.0% <100.0%> (ø)
...vice_api_server/api/dependencies/authentication.py 81.8% <100.0%> (+2.5%) ⬆️
...c/simcore_service_api_server/api/routes/solvers.py 60.0% <100.0%> (+4.7%) ⬆️
...core_service_api_server/api/routes/solvers_jobs.py 90.4% <100.0%> (ø)
...vice_api_server/api/routes/solvers_jobs_getters.py 79.3% <100.0%> (ø)
...imcore_service_api_server/db/repositories/users.py 100.0% <100.0%> (ø)

... and 871 files with indirect coverage changes

@bisgaard-itis bisgaard-itis self-assigned this Nov 1, 2023
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Nov 1, 2023
@bisgaard-itis bisgaard-itis added this to the Microhistory milestone Nov 1, 2023
@bisgaard-itis bisgaard-itis marked this pull request as ready for review November 1, 2023 08:12
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what you mean by "apparently only the webserver and catalog use the product" actually director-v2 as well.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. I left some tips

@bisgaard-itis
Copy link
Contributor Author

not sure what you mean by "apparently only the webserver and catalog use the product" actually director-v2 as well.

Yes, sorry for not being more clear here. What I mean is that the API server seems to only send requests using product info to the catalog and the webserver. I tried to create a unit test for each service to ensure that the product is passed on correctly from the api server, but I couldn't find an API-server endpoint which would send product information directly to the director-v2 without first going over the webserver.

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 1, 2023

Code Climate has analyzed commit 5c6e6c8 and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) November 1, 2023 14:29
@bisgaard-itis bisgaard-itis merged commit 193af65 into ITISFoundation:master Nov 1, 2023
@bisgaard-itis bisgaard-itis deleted the propagate-products-to-entire-backend branch November 1, 2023 14:31
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api-server: Login per Product, not just user. api key/secret include product_name
4 participants