-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Propagate products to entire backend #4961
🎨 Propagate products to entire backend #4961
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4961 +/- ##
=========================================
- Coverage 87.1% 65.2% -21.9%
=========================================
Files 1124 583 -541
Lines 47320 28662 -18658
Branches 976 195 -781
=========================================
- Hits 41223 18702 -22521
- Misses 5879 9911 +4032
+ Partials 218 49 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean by "apparently only the webserver and catalog use the product" actually director-v2 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. I left some tips
services/api-server/src/simcore_service_api_server/api/dependencies/authentication.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/application.py
Show resolved
Hide resolved
Yes, sorry for not being more clear here. What I mean is that the API server seems to only send requests using product info to the catalog and the webserver. I tried to create a unit test for each service to ensure that the product is passed on correctly from the api server, but I couldn't find an API-server endpoint which would send product information directly to the director-v2 without first going over the webserver. |
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit 5c6e6c8 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
Related issue/s
How to test
DevOps Checklist