New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛TEMP: disable override resources #4967

Merged

sanderegg merged 2 commits into ITISFoundation:master from sanderegg:hotfix/disable-update

Nov 1, 2023

Member

sanderegg commented Nov 1, 2023 •

edited

Loading

What do these changes do?

disable override of resources with hardware info, as this fails with dynamic services

Following issues were discovered:

in non-AWS billable (master): there is no clusters-keeper available and this prevents starting any service
in AWS billable: there is currently an issue when starting a dynamic service

Related issue/s

How to test

DevOps Checklist

sanderegg self-assigned this

sanderegg requested review from pcrespov and GitHK as code owners

November 1, 2023 08:33

sanderegg added the a:director-v2 label

sanderegg requested a review from matusdrobuliak66

November 1, 2023 08:34

mrnicegyu11 approved these changes

View reviewed changes

Member

mrnicegyu11 left a comment

fingers crossed

matusdrobuliak66 approved these changes

View reviewed changes

pcrespov approved these changes

View reviewed changes

codecov bot commented Nov 1, 2023 •

edited

Loading

Codecov Report

Merging #4967 (c52bbc1) into master (d1fd4da) will decrease coverage by 20.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #4967      +/-   ##
=========================================
- Coverage    86.9%   66.9%   -20.0%     
=========================================
  Files        1214     508     -706     
  Lines       50382   25876   -24506     
  Branches     1076     195     -881     
=========================================
- Hits        43792   17318   -26474     
- Misses       6353    8509    +2156     
+ Partials      237      49     -188

Flag	Coverage Δ
integrationtests	`60.7% <100.0%> (-4.4%)`	⬇️
unittests	`84.1% <100.0%> (-0.6%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...or_v2/modules/db/repositories/comp_tasks/_utils.py	`72.7% <100.0%> (-2.3%)`	⬇️

... and 979 files with indirect coverage changes

sanderegg added 2 commits

November 1, 2023 10:53


          disable override resources

eeee6da


          disable override resources

c52bbc1

sanderegg force-pushed the hotfix/disable-update branch from 63cf347 to c52bbc1 Compare

November 1, 2023 09:54

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codeclimate bot commented Nov 1, 2023

Code Climate has analyzed commit c52bbc1 and detected 0 issues on this pull request.

View more on Code Climate.

sanderegg merged commit e41af2e into ITISFoundation:master

sanderegg deleted the hotfix/disable-update branch

November 1, 2023 11:13

GitHK mentioned this pull request

🚀 Pre-release master -> staging_sevenPeaks1 #4988

Closed

15 tasks

matusdrobuliak66 mentioned this pull request

🚀 Release v1.63.0 #5027

Closed

29 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mrnicegyu11 mrnicegyu11 approved these changes

pcrespov pcrespov approved these changes

matusdrobuliak66 matusdrobuliak66 approved these changes

GitHK Awaiting requested review from GitHK GitHK is a code owner

Labels