Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Computational backend: re-enable service resources override #4970

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2023

What do these changes do?

  • adds missing tests on POST /computations adding the wallet information, which triggers a bunch of issues
    • RUT returns 404s for frontend services or any service that is not in the database
    • Clusters-keeper errors in deploys where no clusters-keeper is setup
    • update of resources does not work for dynamic services

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 1, 2023
@sanderegg sanderegg self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #4970 (2eb972e) into master (55be1a7) will increase coverage by 11.2%.
The diff coverage is 88.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4970      +/-   ##
=========================================
+ Coverage    76.2%   87.4%   +11.2%     
=========================================
  Files        1183    1026     -157     
  Lines       48692   45668    -3024     
  Branches     1076     537     -539     
=========================================
+ Hits        37123   39956    +2833     
+ Misses      11332    5592    -5740     
+ Partials      237     120     -117     
Flag Coverage Δ
integrationtests 65.0% <29.4%> (-0.1%) ⬇️
unittests 84.9% <88.8%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pi_schemas_resource_usage_tracker/pricing_plans.py 100.0% <100.0%> (ø)
...els-library/src/models_library/resource_tracker.py 100.0% <ø> (ø)
...kages/models-library/src/models_library/wallets.py 100.0% <ø> (ø)
...ore_service_director_v2/api/routes/computations.py 92.2% <100.0%> (+4.9%) ⬆️
...rector_v2/modules/resource_usage_tracker_client.py 75.3% <ø> (+8.6%) ⬆️
...or_v2/modules/db/repositories/comp_tasks/_utils.py 94.3% <92.8%> (+23.7%) ⬆️
...e_tracker/models/resource_tracker_pricing_units.py 95.8% <88.8%> (-4.2%) ⬇️
...simcore_service_webserver/projects/projects_api.py 86.9% <0.0%> (+39.8%) ⬆️

... and 495 files with indirect coverage changes

@sanderegg sanderegg force-pushed the dv-2/override-service-resources branch from 26b3ec9 to 4283d57 Compare November 2, 2023 08:24
@sanderegg sanderegg force-pushed the dv-2/override-service-resources branch from 4283d57 to e63be29 Compare November 2, 2023 12:31
@sanderegg sanderegg marked this pull request as ready for review November 2, 2023 15:21
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for this

@sanderegg sanderegg added this to the 7peaks milestone Nov 2, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thx! left some suggestions.

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 2, 2023

Code Climate has analyzed commit 2eb972e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 looking good

@sanderegg sanderegg merged commit 0ad6ba4 into ITISFoundation:master Nov 3, 2023
@sanderegg sanderegg deleted the dv-2/override-service-resources branch November 3, 2023 07:58
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants