-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Computational backend: re-enable service resources override #4970
🐛Computational backend: re-enable service resources override #4970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4970 +/- ##
=========================================
+ Coverage 76.2% 87.4% +11.2%
=========================================
Files 1183 1026 -157
Lines 48692 45668 -3024
Branches 1076 537 -539
=========================================
+ Hits 37123 39956 +2833
+ Misses 11332 5592 -5740
+ Partials 237 120 -117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
26b3ec9
to
4283d57
Compare
4283d57
to
e63be29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for this
services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thx! left some suggestions.
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit 2eb972e and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 looking good
What do these changes do?
POST /computations
adding the wallet information, which triggers a bunch of issuesRelated issue/s
How to test
DevOps Checklist