-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ director-v2
settings refactoring
#4993
♻️ director-v2
settings refactoring
#4993
Conversation
…r-v2-settings-refactor-followup
Codecov Report
@@ Coverage Diff @@
## master #4993 +/- ##
========================================
Coverage 84.2% 84.2%
========================================
Files 1226 998 -228
Lines 50385 43014 -7371
Branches 1080 554 -526
========================================
- Hits 42457 36259 -6198
+ Misses 7691 6637 -1054
+ Partials 237 118 -119
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/proxy.py
Outdated
Show resolved
Hide resolved
…r-v2-settings-refactor-followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions.
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/__init__.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/__init__.py
Show resolved
Hide resolved
…r-v2-settings-refactor-followup
Code Climate has analyzed commit d62a63c and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
This is the second pass at refactoring the
director-v2
's settings. My objective here was to move them. I would delay other improvements for another PR.This already helps a lot, especially if some part of the dynamic-scheduler needs to ne extracted out of the director-v2.
core/dynamic_services_settings
where all the settings were catalogued and splitBonus:
Related issue/s
dynamic-sidecar
receives prometheus metrics networks if defined ⚠️ #4986How to test
DevOps Checklist