Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ director-v2 settings refactoring #4993

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 7, 2023

What do these changes do?

This is the second pass at refactoring the director-v2's settings. My objective here was to move them. I would delay other improvements for another PR.
This already helps a lot, especially if some part of the dynamic-scheduler needs to ne extracted out of the director-v2.

  • ♻️ added new module core/dynamic_services_settings where all the settings were catalogued and split
  • ⚰️ removed unused dynamic scheduler settings

Bonus:

  • 🐛 trying to address flaky fixture in director-v2 integration testing

Related issue/s

How to test

DevOps Checklist

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #4993 (d62a63c) into master (5abdd71) will increase coverage by 0.0%.
The diff coverage is 92.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4993     +/-   ##
========================================
  Coverage    84.2%   84.2%             
========================================
  Files        1226     998    -228     
  Lines       50385   43014   -7371     
  Branches     1080     554    -526     
========================================
- Hits        42457   36259   -6198     
+ Misses       7691    6637   -1054     
+ Partials      237     118    -119     
Flag Coverage Δ
integrationtests ?
unittests 84.2% <92.3%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e_director_v2/api/dependencies/dynamic_services.py 100.0% <100.0%> (ø)
...ce_director_v2/api/dependencies/dynamic_sidecar.py 77.7% <100.0%> (ø)
...service_director_v2/api/routes/dynamic_services.py 89.8% <100.0%> (ø)
...ctor_v2/core/dynamic_services_settings/__init__.py 100.0% <100.0%> (ø)
..._v2/core/dynamic_services_settings/egress_proxy.py 100.0% <100.0%> (ø)
...irector_v2/core/dynamic_services_settings/proxy.py 100.0% <100.0%> (ø)
...tor_v2/core/dynamic_services_settings/scheduler.py 100.0% <100.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py 98.8% <100.0%> (-0.2%) ⬇️
...re_service_director_v2/modules/dynamic_services.py 96.9% <100.0%> (ø)
...r_v2/modules/dynamic_sidecar/api_client/_public.py 71.1% <100.0%> (ø)
... and 19 more

... and 315 files with indirect coverage changes

@GitHK GitHK self-assigned this Nov 8, 2023
@GitHK GitHK added this to the 7peaks milestone Nov 8, 2023
@GitHK GitHK added t:enhancement Improvement or request on an existing feature a:director-v2 issue related with the director-v2 service labels Nov 8, 2023
@GitHK GitHK marked this pull request as ready for review November 8, 2023 09:22
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions.

@GitHK GitHK requested a review from pcrespov November 8, 2023 10:34
Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit d62a63c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK enabled auto-merge (squash) November 8, 2023 13:30
@GitHK GitHK merged commit 0d9f65d into ITISFoundation:master Nov 8, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants