Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Autoscaling: Debug logs for issue with scaling up #5025

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 13, 2023

What do these changes do?

Some issues are difficult to reproduce locally, such as a full docker swarm.
Therefore some additional logs are needed to better understand the issue that the autoscaling does not scale up by more than 1 machine when multiple s4l are started.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit c59ba16 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg self-assigned this Nov 13, 2023
@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Nov 13, 2023
@sanderegg sanderegg added this to the 7peaks milestone Nov 13, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good luck

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #5025 (c59ba16) into master (0284b24) will decrease coverage by 12.5%.
The diff coverage is n/a.

❗ Current head c59ba16 differs from pull request most recent head 6ee0e70. Consider uploading reports for the commit 6ee0e70 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5025      +/-   ##
=========================================
- Coverage    87.8%   75.3%   -12.5%     
=========================================
  Files         724     121     -603     
  Lines       32726    6705   -26021     
  Branches      689       0     -689     
=========================================
- Hits        28734    5053   -23681     
+ Misses       3835    1652    -2183     
+ Partials      157       0     -157     
Flag Coverage Δ
integrationtests 75.3% <ø> (+10.3%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 667 files with indirect coverage changes

@sanderegg sanderegg force-pushed the bugfix/add-more-some-more-debug-logs-for-autoscaling branch from c59ba16 to 6ee0e70 Compare November 13, 2023 17:08
@sanderegg sanderegg merged commit 6f51597 into ITISFoundation:master Nov 13, 2023
@sanderegg sanderegg deleted the bugfix/add-more-some-more-debug-logs-for-autoscaling branch November 13, 2023 17:09
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants