Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Surface job status #5040

Merged
merged 19 commits into from
Nov 22, 2023
Merged

✨ Surface job status #5040

merged 19 commits into from
Nov 22, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Nov 16, 2023 •
edited
Loading

What do these changes do?

  • Show the status of computational jobs
  • Update the UI for visual improvements

2023-11-21 16 09 10

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 requested a review from ignapas as a code owner November 16, 2023 16:06
@jsaq007 jsaq007 self-assigned this Nov 16, 2023
@jsaq007 jsaq007 added this to the 7peaks milestone Nov 16, 2023
pcrespov
pcrespov reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks really nice! 🎉

sanderegg
sanderegg approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very pretty! 💯

elisabettai
elisabettai approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh woooooooow, for a second I thought you were working on a platform totally different from oSPARC!
Visually amazing.

ignapas
ignapas reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minors:

  • Changing tags makes the bottom ribbon disappear

Peek 2023-11-20 15-03

  • S4L v8 default thumbnail looks a bit off (framing and definition)
  • Selection issue
    image

mguidon
mguidon approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real Nice!

@jsaq007 jsaq007 requested a review from ignapas November 21, 2023 15:13
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

@jsaq007 jsaq007 enabled auto-merge (squash) November 22, 2023 04:15
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit c011293 and detected 0 issues on this pull request.

View more on Code Climate.

@jsaq007 jsaq007 merged commit cc6b89e into ITISFoundation:master Nov 22, 2023
This was referenced Nov 22, 2023
Closed
Closed
jsaq007 added a commit to jsaq007/osparc-simcore that referenced this pull request Nov 27, 2023
@jsaq007 @mrnicegyu11
✨ Surface job status (ITISFoundation#5040)
9800cc5 
Co-authored-by: Dustin Kaiser <8209087+mrnicegyu11@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@ignapas ignapas ignapas approved these changes

@elisabettai elisabettai elisabettai approved these changes

@mguidon mguidon mguidon approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@eofli eofli Awaiting requested review from eofli

Assignees

@jsaq007 jsaq007

Labels
None yet
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.
8 participants
@jsaq007 @ignapas @elisabettai @pcrespov @mguidon @sanderegg @matusdrobuliak66 @mrnicegyu11