Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introduce fake API server entrypoint for logstreaming #5047

Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Nov 17, 2023

What do these changes do?

  • Add initial (fake) entrypoint for streaming logs, so it can be tested from the client side

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Nov 17, 2023
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Nov 17, 2023
@bisgaard-itis bisgaard-itis added this to the 7peaks milestone Nov 17, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) November 17, 2023 15:45
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #5047 (ff54b83) into master (58eb4fd) will decrease coverage by 20.8%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5047      +/-   ##
=========================================
- Coverage    87.0%   66.3%   -20.8%     
=========================================
  Files        1258     591     -667     
  Lines       51615   28919   -22696     
  Branches     1110     198     -912     
=========================================
- Hits        44940   19191   -25749     
- Misses       6435    9678    +3243     
+ Partials      240      50     -190     
Flag Coverage Δ
integrationtests 64.8% <ø> (+1.4%) ⬆️
unittests 82.6% <100.0%> (-2.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vice_api_server/api/routes/solvers_jobs_getters.py 81.2% <100.0%> (+1.9%) ⬆️
.../simcore_service_api_server/models/schemas/jobs.py 96.4% <100.0%> (+0.2%) ⬆️

... and 988 files with indirect coverage changes

Copy link

codeclimate bot commented Nov 17, 2023

Code Climate has analyzed commit ff54b83 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bisgaard-itis bisgaard-itis merged commit 33380f1 into ITISFoundation:master Nov 17, 2023
@bisgaard-itis bisgaard-itis deleted the is4652/initial-log-streaming branch November 30, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants