Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ improving sim4life e2e test #5113

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 30, 2023

What do these changes do?

  • ♻️ improving sim4life e2e test

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
…iak66/osparc-simcore into testing-playwright-framework
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 30, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 30, 2023 15:53
@matusdrobuliak66 matusdrobuliak66 added this to the Kobayashi Maru milestone Nov 30, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Testing playwright framework ♻️ improving sim4life e2e test Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #5113 (25675e8) into master (51ddaac) will decrease coverage by 20.8%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5113      +/-   ##
=========================================
- Coverage    85.6%   64.8%   -20.8%     
=========================================
  Files        1269     526     -743     
  Lines       52149   26660   -25489     
  Branches     1129     198     -931     
=========================================
- Hits        44657   17294   -27363     
- Misses       7252    9316    +2064     
+ Partials      240      50     -190     
Flag Coverage Δ
integrationtests 64.8% <ø> (+<0.1%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1029 files with indirect coverage changes

@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Nov 30, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looking forward to start using this.
I added some suggestions

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice! looking forward to use this. thanks a lot

Copy link

sonarqubecloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codeclimate bot commented Dec 3, 2023

Code Climate has analyzed commit 25675e8 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit 2018f37 into ITISFoundation:master Dec 3, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants