Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes listing in billing center 🚨 #5140

Merged
merged 28 commits into from
Dec 6, 2023

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Dec 5, 2023

What do these changes do?

Bring payment methods back
image

Bonus: The payment gateway window is now slightly wider

Backend

  • environs payment-gateway for development
  • strip secrets from logs
  • refactoring fakes

Related issue/s

How to test

Go to Billing center > Payment methods and check the list

Dev Checklist

@ignapas ignapas added the a:frontend issue affecting the front-end (area group) label Dec 5, 2023
@ignapas ignapas requested review from jsaq007, GitHK and pcrespov December 5, 2023 15:12
@ignapas ignapas self-assigned this Dec 5, 2023
@ignapas ignapas enabled auto-merge (squash) December 5, 2023 15:16
@ignapas ignapas changed the title 🐛 Payment methods list 🐛 Billing center bugs Dec 5, 2023
@pcrespov pcrespov changed the title 🐛 Billing center bugs 🐛 Fixes listing in billing center Dec 5, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to check the ACK via web-sockets and close the poup window
thx so much!

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #5140 (25ba6bf) into master (29b7733) will decrease coverage by 0.3%.
The diff coverage is 91.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5140     +/-   ##
========================================
- Coverage    87.3%   87.1%   -0.3%     
========================================
  Files        1273    1157    -116     
  Lines       52294   49898   -2396     
  Branches     1131     921    -210     
========================================
- Hits        45686   43469   -2217     
+ Misses       6368    6226    -142     
+ Partials      240     203     -37     
Flag Coverage Δ
integrationtests 63.5% <18.3%> (-1.4%) ⬇️
unittests 84.9% <91.1%> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/models_library/api_schemas_payments/socketio.py 100.0% <100.0%> (ø)
...ayments/src/simcore_service_payments/_constants.py 100.0% <100.0%> (ø)
...vice-library/src/servicelib/fastapi/http_client.py 91.0% <83.3%> (+0.6%) ⬆️
...r/src/simcore_service_webserver/payments/_tasks.py 49.2% <0.0%> (ø)
...simcore_service_webserver/payments/_methods_api.py 95.4% <93.7%> (+<0.1%) ⬆️
...simcore_service_webserver/payments/_onetime_api.py 96.2% <92.5%> (+<0.1%) ⬆️

... and 124 files with indirect coverage changes

@ignapas ignapas disabled auto-merge December 5, 2023 17:51
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full stack 💯

Co-authored-by: Sylvain <35365065+sanderegg@users.noreply.github.com>
@pcrespov pcrespov enabled auto-merge (squash) December 5, 2023 18:42
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 25ba6bf and detected 0 issues on this pull request.

View more on Code Climate.

@ignapas
Copy link
Contributor Author

ignapas commented Dec 6, 2023

full stack 💯

hmmm yes sure 😛

@pcrespov pcrespov merged commit 27b1f73 into ITISFoundation:master Dec 6, 2023
@pcrespov pcrespov changed the title 🐛 Fixes listing in billing center 🐛 Fixes listing in billing center 🚨 Dec 6, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants