-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Clusters-keeper: allow for custom boot scripts (⚠️ devops) #5141
✨Clusters-keeper: allow for custom boot scripts (⚠️ devops) #5141
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
========================================
+ Coverage 83.9% 87.0% +3.1%
========================================
Files 1273 1273
Lines 52301 52317 +16
Branches 1133 1133
========================================
+ Hits 43891 45546 +1655
+ Misses 8177 6531 -1646
- Partials 233 240 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc88884
to
cb0a68c
Compare
services/clusters-keeper/src/simcore_service_clusters_keeper/core/settings.py
Show resolved
Hide resolved
services/clusters-keeper/src/simcore_service_clusters_keeper/modules/clusters.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good thanks a lot!
cb0a68c
to
b8ccae6
Compare
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit b8ccae6 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
This PR changes the
PRIMARY_EC2_INSTANCES_ALLOWED_TYPES
environment variable to follow the same pattern as all the otherEC2_INSTANCES_ALLOWED_TYPES
environment variables. E.g. instead of a list of strings, it becomes a dictionary of{InstanceTypeName: {AmiID, [CustomeBootScripts], [PrePullImages]}
.This will allow to add a custom boot script in Ops repository to redirect logs of the primary machine towards Graylog or any logs aggregator
Related issue/s
How to test
Dev Checklist
DevOps Checklist
PRIMARY_EC2_INSTANCES_AMI_ID
deprecated, can be safely removedPRIMARY_EC2_INSTANCES_ALLOWED_TYPES
becomes a json dictionary ->'{"t2.medium":"ami_id": "XXXXXXXX", "custom_boot_scripts": ["whoami"]}}'