Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Clusters-keeper: allow for custom boot scripts (⚠️ devops) #5141

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 6, 2023

What do these changes do?

This PR changes the PRIMARY_EC2_INSTANCES_ALLOWED_TYPES environment variable to follow the same pattern as all the other EC2_INSTANCES_ALLOWED_TYPES environment variables. E.g. instead of a list of strings, it becomes a dictionary of {InstanceTypeName: {AmiID, [CustomeBootScripts], [PrePullImages]}.

This will allow to add a custom boot script in Ops repository to redirect logs of the primary machine towards Graylog or any logs aggregator

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added this to the Kobayashi Maru milestone Dec 6, 2023
@sanderegg sanderegg self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5141 (b8ccae6) into master (fd0c017) will increase coverage by 3.1%.
The diff coverage is 92.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5141     +/-   ##
========================================
+ Coverage    83.9%   87.0%   +3.1%     
========================================
  Files        1273    1273             
  Lines       52301   52317     +16     
  Branches     1133    1133             
========================================
+ Hits        43891   45546   +1655     
+ Misses       8177    6531   -1646     
- Partials      233     240      +7     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 85.2% <92.8%> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...imcore_service_clusters_keeper/modules/clusters.py 100.0% <100.0%> (ø)
.../simcore_service_clusters_keeper/utils/clusters.py 75.0% <100.0%> (+1.0%) ⬆️
...c/simcore_service_clusters_keeper/core/settings.py 95.6% <83.3%> (-2.0%) ⬇️

... and 108 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/add-ec2-tags branch from dc88884 to cb0a68c Compare December 6, 2023 10:58
@sanderegg sanderegg marked this pull request as ready for review December 6, 2023 10:58
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good thanks a lot!

@sanderegg sanderegg force-pushed the comp-backend/add-ec2-tags branch from cb0a68c to b8ccae6 Compare December 6, 2023 15:27
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit b8ccae6 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg changed the title ✨Clusters-keeper: allow for custom boot scripts ✨Clusters-keeper: allow for custom boot scripts (⚠️ devops) Dec 6, 2023
@sanderegg sanderegg merged commit d57990f into ITISFoundation:master Dec 6, 2023
@sanderegg sanderegg deleted the comp-backend/add-ec2-tags branch December 6, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants