Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Publishing as Tutorials - PO TESTER and ADMIN #5143

Merged
merged 2 commits into from
Dec 6, 2023
Merged

🐛 Publishing as Tutorials - PO TESTER and ADMIN #5143

merged 2 commits into from
Dec 6, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Dec 6, 2023 •
edited
Loading

What do these changes do?

Fixes the issue where users could publish templates to all users of the product

PRODUCT_OWNER TESTERS AND ADMIN

Screenshot 2023-12-06 at 11 27 52

USER

Screenshot 2023-12-06 at 11 28 31

Related issue/s

Resolves https://z43.fogbugz.com/f/cases/reply/190171/?ixBugEventEmail=1355244

How to test

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 self-assigned this Dec 6, 2023
@jsaq007 jsaq007 enabled auto-merge (squash) December 6, 2023 10:31
pcrespov
pcrespov reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elisabettai
elisabettai approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, it looks good.

ignapas
ignapas approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it myself but looking good

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 0e88fa4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

eofli
eofli approved these changes Dec 6, 2023
View reviewed changes
Copy link

@eofli eofli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsaq007 jsaq007 merged commit fd0c017 into ITISFoundation:master Dec 6, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 12, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@ignapas ignapas ignapas approved these changes

@elisabettai elisabettai elisabettai approved these changes

@eofli eofli eofli approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@jsaq007 jsaq007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsaq007 @ignapas @elisabettai @pcrespov @eofli