-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is922/add csv export functionality (⚠️ devops) #5258
✨ Is922/add csv export functionality (⚠️ devops) #5258
Conversation
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Please check the comments and come back to me if you have any questions on my suggetions
...tracker/src/simcore_service_resource_usage_tracker/services/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
...tracker/src/simcore_service_resource_usage_tracker/services/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
...tracker/src/simcore_service_resource_usage_tracker/services/resource_tracker_service_runs.py
Outdated
Show resolved
Hide resolved
...resource-usage-tracker/tests/unit/with_dbs/test_api_resource_tracker_service_runs__export.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/resource_usage/_service_runs_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__export.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__export.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__export.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good! I have a few comments/questions and we can gladly go through.
...ource-usage-tracker/src/simcore_service_resource_usage_tracker/api/rest/_resource_tracker.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/settings.py
Outdated
Show resolved
Hide resolved
...resource-usage-tracker/tests/unit/with_dbs/test_api_resource_tracker_service_runs__export.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_usage_services__export.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the ENV PR 👍
...ource-usage-tracker/src/simcore_service_resource_usage_tracker/api/rest/_resource_tracker.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/resource_usage/_service_runs_handlers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider my suggestion
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some more comments for the next PR coming. thanks a lot.
What do these changes do?
simcore-<deployment>-rds-exports
bucket.SELECT * from aws_s3.query_export_to_s3('{your query}', aws_commons.create_s3_uri('{bucket_name}', '{s3_key}', 'us-east-1'), 'format csv, HEADER true');
First version doesn't expect huge data, therefore discussed with @ignapas and implemented as redirect:

Related issue/s
How to test
Dev Checklist
DevOps Checklist
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/317
RESOURCE_USAGE_TRACKER_S3
env var filled with the correct value for