Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is922/add csv export functionality (⚠️ devops) #5258

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 19, 2024

What do these changes do?

  • ✨ Introducing CSV export functionality using postgres aws-s3 extension (Can be reused for any Postgres to S3 export of data, also tested for huge exports with a couple of GBs)
  • Concept:
    • I have added an RDS policy that can export data only! to the simcore-<deployment>-rds-exports bucket.
    • Installed RDS extension
    • You can use the code: SELECT * from aws_s3.query_export_to_s3('{your query}', aws_commons.create_s3_uri('{bucket_name}', '{s3_key}', 'us-east-1'), 'format csv, HEADER true');
    • Using a pre-signed download link we give access to the file for 2 hours.
    • Bucket policy is set that it deletes the data that's there longer than 2 days

First version doesn't expect huge data, therefore discussed with @ignapas and implemented as redirect:
image

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Please check the comments and come back to me if you have any questions on my suggetions

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good! I have a few comments/questions and we can gladly go through.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the ENV PR 👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider my suggestion

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more comments for the next PR coming. thanks a lot.

@matusdrobuliak66 matusdrobuliak66 merged commit d6b958e into ITISFoundation:master Jan 25, 2024
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants