🐛 Is922/wrong-null-substitution #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
matusdrobuliak66
requested review from
sanderegg,
mrnicegyu11 and
YuryHrytsuk
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5269 +/- ##
========================================
- Coverage 86.4% 77.3% -9.2%
========================================
Files 1306 1306
Lines 53510 53510
Branches 1170 1170
========================================
- Hits 46280 41368 -4912
- Misses 6981 11900 +4919
+ Partials 249 242 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
approved these changes
Jan 25, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When providing in config file
RESOURCE_USAGE_TRACKER_S3=nullIn docker-compose yaml file environment section this:
- RESOURCE_USAGE_TRACKER_S3=${RESOURCE_USAGE_TRACKER_S3}substitutes for empty string,while
RESOURCE_USAGE_TRACKER_S3: ${RESOURCE_USAGE_TRACKER_S3}substitutes correctly to null valueRelated issue/s
How to test
Dev Checklist
DevOps Checklist