-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Is922/adding email field to usage endpoint #5291
🎨 Is922/adding email field to usage endpoint #5291
Conversation
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5291 +/- ##
========================================
- Coverage 86.8% 85.4% -1.4%
========================================
Files 970 1097 +127
Lines 40557 48030 +7473
Branches 824 551 -273
========================================
+ Hits 35211 41028 +5817
- Misses 5167 6881 +1714
+ Partials 179 121 -58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Just a small remark. thx!
packages/models-library/src/models_library/api_schemas_resource_usage_tracker/service_runs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address PC's concern.
thanks!
packages/models-library/src/models_library/api_schemas_resource_usage_tracker/service_runs.py
Show resolved
Hide resolved
|
What do these changes do?
user_email
to the listing of resource usagemake openapi-specs
also some TLSAuthentication was added to the specs, probably from some previous PR.Related issue/s
How to test
Dev Checklist
DevOps Checklist