Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Is922/adding email field to usage endpoint #5291

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Feb 2, 2024

What do these changes do?

  • 🎨 as requested by @ignapas adding user_email to the listing of resource usage
  • NOTE: by running make openapi-specs also some TLSAuthentication was added to the specs, probably from some previous PR.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 2, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the This is Sparta! milestone Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb9eecc) 86.8% compared to head (b5c9672) 85.4%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5291     +/-   ##
========================================
- Coverage    86.8%   85.4%   -1.4%     
========================================
  Files         970    1097    +127     
  Lines       40557   48030   +7473     
  Branches      824     551    -273     
========================================
+ Hits        35211   41028   +5817     
- Misses       5167    6881   +1714     
+ Partials      179     121     -58     
Flag Coverage Δ
integrationtests 65.2% <ø> (-0.1%) ⬇️
unittests 82.8% <100.0%> (-2.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...api_schemas_resource_usage_tracker/service_runs.py 100.0% <100.0%> (ø)
..._tracker/services/resource_tracker_service_runs.py 100.0% <ø> (ø)
...webserver/resource_usage/_service_runs_handlers.py 97.2% <ø> (ø)

... and 642 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 2, 2024 12:33
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Is922/adding email field to usage endpoint 🎨 Is922/adding email field to usage endpoint Feb 2, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Just a small remark. thx!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address PC's concern.
thanks!

Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 5, 2024 06:06
@matusdrobuliak66 matusdrobuliak66 merged commit bc5baf5 into ITISFoundation:master Feb 5, 2024
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants