Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming dynamic-scheduler in docker-compose files #5297

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 5, 2024

What do these changes do?

Due to limitations in how long the hostnames are, on some deployments it is not possible to use the full name dynamic-scheduler, instead using dynamic-schdlr will work.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Feb 5, 2024
@GitHK GitHK added this to the This is Sparta! milestone Feb 5, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Feb 5, 2024
@GitHK GitHK marked this pull request as ready for review February 5, 2024 09:13
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So putting them side-to-side with sidecar, i think you can add some vowel to it to make it a bit more readable :-)
scheduler
schdlr
schdler
sidecar

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2240f7b) 87.3% compared to head (57605e1) 87.3%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5297   +/-   ##
======================================
  Coverage    87.3%   87.3%           
======================================
  Files        1316    1316           
  Lines       53846   53846           
  Branches     1173    1173           
======================================
+ Hits        47015   47016    +1     
+ Misses       6581    6580    -1     
  Partials      250     250           
Flag Coverage Δ
integrationtests 65.1% <ø> (-0.1%) ⬇️
unittests 85.1% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@GitHK GitHK enabled auto-merge (squash) February 5, 2024 09:21
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK merged commit 75e4585 into ITISFoundation:master Feb 6, 2024
55 checks passed
@GitHK GitHK deleted the pr-osparc-rename-service branch February 6, 2024 07:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants