-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming dynamic-scheduler
in docker-compose files
#5297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So putting them side-to-side with sidecar
, i think you can add some vowel to it to make it a bit more readable :-)
scheduler
schdlr
schdler
sidecar
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5297 +/- ##
======================================
Coverage 87.3% 87.3%
======================================
Files 1316 1316
Lines 53846 53846
Branches 1173 1173
======================================
+ Hits 47015 47016 +1
+ Misses 6581 6580 -1
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What do these changes do?
Due to limitations in how long the hostnames are, on some deployments it is not possible to use the full name
dynamic-scheduler
, instead usingdynamic-schdlr
will work.Related issue/s
dynamic-scheduler
fails to start on TIP osparc-ops-environments#503How to test
Dev Checklist
DevOps Checklist