Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Making service start progress UI user readable #5298

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 5, 2024

What do these changes do?

  • Renamed progress element details to make it more user friendly for non developer users.
  • Items are now displayed in the order they are done in the backend

Screenshot 2024-02-05 at 10 41 36

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK changed the title 🎨 Renaming 🎨 Making service start progress UI user friendly Feb 5, 2024
@GitHK GitHK self-assigned this Feb 5, 2024
@GitHK GitHK added this to the This is Sparta! milestone Feb 5, 2024
@GitHK GitHK added the a:frontend issue affecting the front-end (area group) label Feb 5, 2024
@GitHK GitHK marked this pull request as ready for review February 5, 2024 10:45
@GitHK GitHK requested review from jsaq007 and ignapas as code owners February 5, 2024 10:45
@GitHK GitHK changed the title 🎨 Making service start progress UI user friendly 🎨 Making service start progress UI user readable Feb 5, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the suggestion from @mguidon here, I'd just show these steps:

  1. Installing platform services...
  2. Increasing system capacity...
  3. Installing software...
  4. Downloading files...

For our (dev) understanding

  1. corresponds to pulling sidecar (which is normally very fast)
  2. corresponds to autoscaling
  3. corresponds to pulling images
  4. corresponds to download outputs+state+inputs (users don't care about what exactly is being downloaded, but it would be nice if they understand that the more/bigger files they have, the slower this step will be.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK
Copy link
Contributor Author

GitHK commented Feb 5, 2024

Following the suggestion from @mguidon here, I'd just show these steps:

  1. Installing platform services...
  2. Increasing system capacity...
  3. Installing software...
  4. Downloading files...

For our (dev) understanding

  1. corresponds to pulling sidecar (which is normally very fast)
  2. corresponds to autoscaling
  3. corresponds to pulling images
  4. corresponds to download outputs+state+inputs (users don't care about what exactly is being downloaded, but it would be nice if they understand that the more/bigger files they have, the slower this step will be.

@elisabettai I'm not sure how to deal with the removal of the sections without crashing the FE. I would leave that part to someone with more Javascript experience. If it is really required to hide those parts.

@elisabettai
Copy link
Collaborator

Following the suggestion from @mguidon here, I'd just show these steps:

  1. Installing platform services...
  2. Increasing system capacity...
  3. Installing software...
  4. Downloading files...

For our (dev) understanding

  1. corresponds to pulling sidecar (which is normally very fast)
  2. corresponds to autoscaling
  3. corresponds to pulling images
  4. corresponds to download outputs+state+inputs (users don't care about what exactly is being downloaded, but it would be nice if they understand that the more/bigger files they have, the slower this step will be.

@elisabettai I'm not sure how to deal with the removal of the sections without crashing the FE. I would leave that part to someone with more Javascript experience. If it is really required to hide those parts.

I see @GitHK , I thought that the file you edited was the only place where those steps were defined and that was relatively easy to test if you were to break the FE.

I've also added some proposal for rephrasing some of the messages.

@GitHK GitHK requested a review from elisabettai February 5, 2024 16:04
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK enabled auto-merge (squash) February 6, 2024 09:48
@GitHK GitHK merged commit a145762 into ITISFoundation:master Feb 6, 2024
49 checks passed
@GitHK GitHK deleted the pr-osparc-better-log-messages branch February 6, 2024 10:01
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants