🐛 Autoscaling: issues with labelled drained nodes

[sanderegg]

What do these changes do?

#5340 introduced a big change on how nodes are treated.
A few issues were found that this PR should fix:

• terminating node was relying on the docker node UpdatedAt field which is not changed anymore the same way as when the node was drained/activated via docker facilities
• the label for osparc readyness was changed to follow inverse URL notations

NOTE: these changes are compatible with both modes.

Related issue/s

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68b681c) 87.3% compared to head (9483e54) 66.5%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5348      +/-   ##
=========================================
- Coverage    87.3%   66.5%   -20.8%     
=========================================
  Files        1321     568     -753     
  Lines       54167   28630   -25537     
  Branches     1172     202     -970     
=========================================
- Hits        47310   19057   -28253     
- Misses       6607    9523    +2916     
+ Partials      250      50     -200     

Flag	Coverage Δ
integrationtests	65.0% <ø> (-0.1%)	⬇️
unittests	95.6% <100.0%> (+10.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rc/simcore_service_autoscaling/core/application.py	97.8% <100.0%> (+0.2%)	⬆️
...e_service_autoscaling/modules/auto_scaling_core.py	94.3% <100.0%> (+<0.1%)	⬆️
.../simcore_service_autoscaling/utils/utils_docker.py	99.1% <100.0%> (+<0.1%)	⬆️

... and 1086 files with indirect coverage changes

[pcrespov]

thx!

[matusdrobuliak66]

thanks 💯

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud