-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 HTTPException -> JSONResponse: fix exception handler in api-server #5385
Merged
bisgaard-itis
merged 3 commits into
ITISFoundation:master
from
bisgaard-itis:5384-fix-exception-handler-in-api-server
Feb 28, 2024
Merged
🐛 HTTPException -> JSONResponse: fix exception handler in api-server #5385
bisgaard-itis
merged 3 commits into
ITISFoundation:master
from
bisgaard-itis:5384-fix-exception-handler-in-api-server
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5385 +/- ##
=========================================
- Coverage 87.5% 65.7% -21.8%
=========================================
Files 1322 613 -709
Lines 54221 29878 -24343
Branches 1174 203 -971
=========================================
- Hits 47465 19647 -27818
- Misses 6507 10180 +3673
+ Partials 249 51 -198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
approved these changes
Feb 28, 2024
sanderegg
approved these changes
Feb 28, 2024
|
pcrespov
approved these changes
Feb 28, 2024
services/api-server/src/simcore_service_api_server/api/errors/httpx_client_error.py
Show resolved
Hide resolved
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Feb 28, 2024
17 tasks
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Mar 4, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
HTTPExceptions
and returns them to the client with status code 500 because I should be usingJSONResponse
instead.Related issue/s
How to test
Dev Checklist
DevOps Checklist