Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Autoscaling/Clusters-keeper tags also volume and network-interface #5405

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 4, 2024

What do these changes do?

This PR adds tagging of the EC2 linked EBS storage and Network-interfaces for better cost monitoring.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added a:autoscaling autoscaling service in simcore's stack a:clusters-keeper labels Mar 4, 2024
@sanderegg sanderegg added this to the Schoggilebe milestone Mar 4, 2024
@sanderegg sanderegg self-assigned this Mar 4, 2024
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.7%. Comparing base (2aa73cc) to head (b146ea1).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5405      +/-   ##
=========================================
- Coverage    87.5%   86.7%    -0.9%     
=========================================
  Files        1322     959     -363     
  Lines       54234   42418   -11816     
  Branches     1175     228     -947     
=========================================
- Hits        47479   36780   -10699     
+ Misses       6506    5589     -917     
+ Partials      249      49     -200     
Flag Coverage Δ
integrationtests 59.8% <ø> (-5.4%) ⬇️
unittests 85.0% <100.0%> (-0.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/aws-library/src/aws_library/ec2/client.py 100.0% <100.0%> (ø)

... and 402 files with indirect coverage changes

@sanderegg sanderegg merged commit f76d9e1 into ITISFoundation:master Mar 4, 2024
55 checks passed
@sanderegg sanderegg deleted the autoscaling/label-volume-and-network-interface branch March 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack a:clusters-keeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaling/Clusters-keeper: label volumes and network interfaces
3 participants