Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add validators to ProjectDB model #5810

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 14, 2024

What do these changes do?

  • 🐛 add validators to ProjectDB model

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 14, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Leeroy Jenkins milestone May 14, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 14, 2024 04:44
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (cafbf96) to head (d26b0f7).
Report is 197 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5810      +/-   ##
=========================================
- Coverage    84.5%   81.7%    -2.9%     
=========================================
  Files          10     558     +548     
  Lines         214   28232   +28018     
  Branches       25     205     +180     
=========================================
+ Hits          181   23083   +22902     
- Misses         23    5097    +5074     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 65.1% <100.0%> (?)
unittests 87.0% <100.0%> (+2.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...r/src/simcore_service_webserver/projects/models.py 100.0% <100.0%> (ø)

... and 567 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 14, 2024 06:20
@matusdrobuliak66 matusdrobuliak66 merged commit 25f91df into ITISFoundation:master May 14, 2024
56 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the fix-project-db-model branch May 14, 2024 06:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 12, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants