-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix for pending transactions #5852
🐛 fix for pending transactions #5852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5852 +/- ##
=========================================
- Coverage 84.5% 65.0% -19.6%
=========================================
Files 10 593 +583
Lines 214 29515 +29301
Branches 25 205 +180
=========================================
+ Hits 181 19189 +19008
- Misses 23 10274 +10251
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 😄
...usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker_background_task.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not cover the case where the pricing_unit_cost would be None with this fix. Please check my comment, thanks!
...usage-tracker/src/simcore_service_resource_usage_tracker/resource_tracker_background_task.py
Outdated
Show resolved
Hide resolved
…o bugfix/not-closing-transaction
|
What do these changes do?
bool(Decimal(0))
as False, which is not intended.Related issue/s
How to test
services/resource-usage-tracker/tests/unit/with_dbs/test_process_rabbitmq_message_with_billing_cost_0.py
Dev-ops checklist