Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAB & default agent comparison Experiment #50

Draft
wants to merge 73 commits into
base: main
Choose a base branch
from

Conversation

maypink
Copy link
Collaborator

@maypink maypink commented Aug 11, 2023

This branch contains code from both transfer_to_lightning_with_dbv0 and docker_and_experiments branches.
What's new:

  • Setup for experiments to compare original version of FEDOT with FEDOT with the use of contextual MAB and surrogate model.

NB! To install appropriate GOLEM branch:
pip install git+https://github.com/aimclub/GOLEM@minor-fix#egg=thegolem
To install appropriate FEDOT branch:
pip install git+https://github.com/aimclub/FEDOT@add-mutation-agent#egg=fedot --no-deps

@aim-pep8-bot
Copy link

aim-pep8-bot commented Aug 11, 2023

Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 279:13: E126 continuation line over-indented for hanging indent
Line 287:9: E121 continuation line under-indented for hanging indent
Line 356:5: F841 local variable 'e' is assigned to but never used

Line 7:1: F401 'golem.core.optimisers.adaptive.context_agents.ContextAgentTypeEnum' imported but unused
Line 21:1: F401 'meta_automl.meta_algorithm.model_advisors.DiverseFEDOTPipelineAdvisor' imported but unused
Line 44:121: E501 line too long (125 > 120 characters)
Line 51:121: E501 line too long (131 > 120 characters)
Line 53:121: E501 line too long (131 > 120 characters)

Line 6:1: F401 'typing.Any' imported but unused
Line 13:1: F401 'fedot.core.pipelines.node.PrimaryNode' imported but unused
Line 14:1: F401 'fedot.core.pipelines.pipeline.Pipeline' imported but unused
Line 76:13: E126 continuation line over-indented for hanging indent
Line 80:9: E121 continuation line under-indented for hanging indent

Line 16:121: E501 line too long (128 > 120 characters)
Line 45:9: E121 continuation line under-indented for hanging indent
Line 45:9: E125 continuation line with same indent as next logical line

Line 100:67: W292 no newline at end of file

Comment last updated at 2023-08-18 09:47:33 UTC

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (transfer_to_lightning_with_dbv0@d9fa79b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 04a2ae6 differs from pull request most recent head 95ce942. Consider uploading reports for the commit 95ce942 to get more accurate results

@@                        Coverage Diff                         @@
##             transfer_to_lightning_with_dbv0      #50   +/-   ##
==================================================================
  Coverage                                   ?   42.25%           
==================================================================
  Files                                      ?       26           
  Lines                                      ?      594           
  Branches                                   ?        0           
==================================================================
  Hits                                       ?      251           
  Misses                                     ?      343           
  Partials                                   ?        0           

Egor Shikov and others added 13 commits August 11, 2023 21:19
* update requirements.txt

* remove deprecated argument "dataset_format" from "OpenMLDataset.get_data()"
* alter categorical features transformation to "one-hot" if pymfe raised RecursionError

* allow datasets data to not have "categorical_indicator" for pymfe

* allow to specify kwargs for MFE.fit() & MFE.extract() in PymfeExtractor.extract()
* Create .codecov.yml

* Create build.yml

* Update README.md

add few bages

* Update README.md

Add new bages

* Update README.md

removed nccr badge
patch broken build badge
* update versions in requirements.txt

* split requirements.txt into constant & variable versions

* fix test_custom_dataset.py according to #39

* update data for cached test datasets (presumably for #39)
@maypink maypink force-pushed the fedot-comparison-experiment branch from 04a2ae6 to 9220f92 Compare August 15, 2023 08:41
@maypink maypink changed the base branch from main to transfer_to_lightning_with_dbv0 August 15, 2023 12:48
@maypink maypink requested a review from gkirgizov August 15, 2023 12:49
Copy link
Member

@gkirgizov gkirgizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На первый взгляд комментариев нет. Ждем результатов

@ChernyakKonstantin ChernyakKonstantin force-pushed the transfer_to_lightning_with_dbv0 branch from 97c167f to 25b5375 Compare October 3, 2023 21:14
@MorrisNein MorrisNein force-pushed the transfer_to_lightning_with_dbv0 branch from add3659 to c19b7bd Compare October 25, 2023 12:33
Base automatically changed from transfer_to_lightning_with_dbv0 to main October 27, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants