Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory overflow and Expand model validation #33

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

6Naci
Copy link
Contributor

@6Naci 6Naci commented Jul 4, 2023

  • Removing unnecessary computational graph when using the cache
  • General conformity check (of the last layer) for the cache_model

@SuperSashka
Copy link
Member

Ну можно вливать, получается. @nikiniki1 не забудь сделать ребейз, на этот PR, когда доделаешь примеры.

This RP serves for performance fixes concerning excessive computational graph saving and work with cache when output layer is not linear.

@6Naci 6Naci merged commit ee1e5c5 into ITMO-NSS-team:main Jul 6, 2023
nikiniki1 added a commit that referenced this pull request Jul 26, 2023
* Refactor + adaptive lambdas

Currently adaptive lambdas are not working due to pytorch features.

* Update lambdas

Now adaptive lambdas are working

* Update docstrings

* Some fixes + new example

- Fix for output for Fourier features
- Adaptive lambdas now work for systems
- 1D Navier-Stokes example

* Fix for examples

Small fixes for examples and docstrings

* Compatibility fix

* Solution initialization fix for mat

* LV img save fix

* Fix memory overflow and Expand model validation (#33)

* Fix memory overflow and Expand model validation

* Version update for actions

---------

Co-authored-by: Titov Roman <r.titov@itmo.ru>
Co-authored-by: SuperSashka <heretik.unlimited@gmail.com>

* Updated lambdas

NTK -> sensitivity analysis

* Update derivative.py

Docstrings update

* Some fixes + docstrings

Updated project structure.
- new modules ('eval' for evaluating operator and boundaries, 'losses' for all losses).
Minor improvements due to new improvements.

* Refactor + adaptive lambdas

Currently adaptive lambdas are not working due to pytorch features.

* Update lambdas

Now adaptive lambdas are working

* Update docstrings

* Some fixes + new example

- Fix for output for Fourier features
- Adaptive lambdas now work for systems
- 1D Navier-Stokes example

* Fix for examples

Small fixes for examples and docstrings

* Compatibility fix

* Solution initialization fix for mat

* LV img save fix

* Updated lambdas

NTK -> sensitivity analysis

* Some fixes + docstrings

Updated project structure.
- new modules ('eval' for evaluating operator and boundaries, 'losses' for all losses).
Minor improvements due to new improvements.

* Cache fix for lambdas

* Small fixes

* Cache fix

* Normalized loss

Added normalized loss as stop criterion

* loss -> normalized_loss in cache, small exp fix

* Experiment fix

* example rework

* Cache fix

Fixed a bug with the same loss when using the cache

* Small cache fix

* More predictable cache directory

* Example fix

* Clear cache functionality

---------

Co-authored-by: SuperSashka <heretik.unlimited@gmail.com>
Co-authored-by: Roman Titov <47646069+6Naci@users.noreply.github.com>
Co-authored-by: Titov Roman <r.titov@itmo.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants