-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated setActiveWallet.ts for fetching test wallet address #48
Updated setActiveWallet.ts for fetching test wallet address #48
Conversation
🦋 Changeset detectedLatest commit: e259360 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the documentation as well by adding this new step definition in the https://github.com/ITZSHOAIB/chukti/blob/master/docs/step-definitions/blockchain.md
|
||
export const fetchWalletByIndexStep = async (index: number) => { | ||
const testWallet = await getTestWalletAddress({ index }); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!world.chukti) { | |
world.chukti = {}; | |
} | |
world.chukti.lastResult = testWallet | |
We need to store it in the lastResult
property so that user will be able to store this data using I store the result in {string} step definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sir, I will be doing that and creating a new updated pull request! Thank you for inputs
Please check sir , are the requirements filled now.. Please let me know if I missed something! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue: #29
This pull request introduces new step definitions to enhance our testing framework by allowing the retrieval of wallet addresses based on their index from a local blockchain . This functionality is essential for improving our interaction with test wallets, making it easier to manage and validate wallet addresses during testing.
Changes Made:
fetchWalletByIndexStep
function tosetActiveWallet.js
, which allows users to fetch and log the wallet address corresponding to a specified index without setting it as the active wallet.Example usage