Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #31

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix tests #31

merged 4 commits into from
Jan 16, 2025

Conversation

mtfishman
Copy link
Member

No description provided.

@mtfishman
Copy link
Member Author

@lkdvos for now I moved all of the tests to the base directory test which seems to circumvent the issue of some of the tests not running (and exposes the bug in block diagonal arrays).

@lkdvos
Copy link
Contributor

lkdvos commented Jan 16, 2025

Is it possible to use some kind of @test_broken way of marking that? If it's too much hassle, probably not worth it, but ti is a bit more visible that way

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (10ea80c) to head (94e164e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #31       +/-   ##
===========================================
+ Coverage   27.19%   74.27%   +47.08%     
===========================================
  Files          29       29               
  Lines         993     1003       +10     
===========================================
+ Hits          270      745      +475     
+ Misses        723      258      -465     
Flag Coverage Δ
docs 26.66% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member Author

Is it possible to use some kind of @test_broken way of marking that? If it's too much hassle, probably not worth it, but ti is a bit more visible that way

I tried, but @test_broken test_svd(a, usv) doesn't work, it would require modifying test_svd. Though maybe that is worth doing, I can add a broken kwarg to test_svd.

@mtfishman
Copy link
Member Author

Also another unfortunate thing is that diagind(::Diagonal, ::IndexCartesian) isn't defined in Julia v1.10.

@mtfishman mtfishman merged commit 60ec997 into main Jan 16, 2025
12 checks passed
@mtfishman mtfishman deleted the fix_tests branch January 16, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants