Add new Observer that gets updated after each time step
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often we just want the
Observerto get updated after the full time step, however the current one gets updated at each bond.This PR adds a new
step_observer!keyword argument totdvpwhere a user can pass anObserverthat only gets updated at the end of the entire time step. This makes it simpler to define functions for that observer, since you don't have to check which fractional sweep and bond you are on like you would with the default observer. See the tests for an example.I've also added an example code for making a custom TDVP with non-uniform time steps. We may want to support that natively by having a
time_stepskeyword argument where you can specify a vector of time steps. The total time would be determined from the sum of the time steps and the number of steps/sweeps would be the length of the vector of time steps.