Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Use QR in QN factorize #1195

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[ITensors] Use QR in QN factorize #1195

merged 2 commits into from
Sep 14, 2023

Conversation

mtfishman
Copy link
Member

Description

Use QR in QN factorize.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -18.04% ⚠️

Comparison is base (048e69a) 85.40% compared to head (4b6f5b4) 67.37%.

❗ Current head 4b6f5b4 differs from pull request most recent head 811c0b0. Consider uploading reports for the commit 811c0b0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1195       +/-   ##
===========================================
- Coverage   85.40%   67.37%   -18.04%     
===========================================
  Files          88       87        -1     
  Lines        8427     8388       -39     
===========================================
- Hits         7197     5651     -1546     
- Misses       1230     2737     +1507     
Files Changed Coverage Δ
src/tensor_operations/matrix_decomposition.jl 91.54% <100.00%> (-0.74%) ⬇️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member Author

[benchmark]

@mtfishman mtfishman merged commit f6c575b into main Sep 14, 2023
7 checks passed
@mtfishman mtfishman deleted the ITensors_qr_qn_factorize branch September 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants