[ITensorMPS] Fix some lingering namespace issues

[emstoudenmire]

Fixes of test errors in test/ITensorMPS/Ops/ and the ITensorGaussianMPS package.

Also attempting to fix the error seen when running the ITensorGPU tests.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 53.45%. Comparing base (2567204) to head (361de4e).

❗ Current head 361de4e differs from pull request most recent head de5f118. Consider uploading reports for the commit de5f118 to get more accurate results

Files	Patch %	Lines
src/ITensorMPS/abstractprojmpo/projmposum.jl	0.00%	3 Missing ⚠️
src/ITensorMPS/dmrg.jl	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1362       +/-   ##
===========================================
- Coverage   84.13%   53.45%   -30.68%     
===========================================
  Files         100       99        -1     
  Lines        8527     8452       -75     
===========================================
- Hits         7174     4518     -2656     
- Misses       1353     3934     +2581     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emstoudenmire]

[test ITensors mps]

[emstoudenmire]

[test ITensorGaussianMPS]

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8415394326

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8415394326

[github-actions]

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/8415370522

[github-actions]

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/8415370522

[emstoudenmire]

So the test failure here for the MPS tests is strange: apparently allequal was not defined in Base until Julia 1.8. But it is used in some @assert's in the file abstractprojmpo/projmposum.jl. So I'm surprised these tests were ever passing.

The question is whether we should:

1. replace the use of allequal with something else there or
2. raise the minimum Julia version to 1.8

I'd be fine with either but I think for now better to just replace allequal if we are just using it in a small number of places.

[emstoudenmire]

[test ITensors mps]

[emstoudenmire]

[test ITensorGaussianMPS]

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8416208821

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8416208821

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8416207106

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8416207106

[emstoudenmire]

I went ahead and replaced allequal but let's discuss which choice would be best.

[mtfishman]

So the test failure here for the MPS tests is strange: apparently allequal was not defined in Base until Julia 1.8. But it is used in some @assert's in the file abstractprojmpo/projmposum.jl. So I'm surprised these tests were ever passing.

The question is whether we should:

1. replace the use of `allequal` with something else there or

2. raise the minimum Julia version to 1.8

I'd be fine with either but I think for now better to just replace allequal if we are just using it in a small number of places.

I've been using the Compat.jl package to address issues like that. Compat.jl makes some subset of newer Julia functionality (like allequal) available in older versions of Julia. Probably it was working before because we load Compat in ITensors.jl, but it isn't being loaded in the ITensorMPS module now. So we could add using Compat: allequal at the top of the abstractprojmpo/projmposum.jl file.

[mtfishman]

[test ITensors mps]

We should change the trigger comment for this workflow to [test ITensorMPS], it just requires changing this line: https://github.com/ITensor/ITensors.jl/blob/v0.3.57/.github/workflows/comment_trigger_test_itensors_mps.yml#L12.

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8420084779

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8420084779

[emstoudenmire]

[test ITensors mps]

[emstoudenmire]

[test ITensorGaussianMPS]

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8421425459

[github-actions]

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8421425459

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8421423550

[github-actions]

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8421423550