Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix entanglement entropy example #1369

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[Docs] Fix entanglement entropy example #1369

merged 2 commits into from
Mar 28, 2024

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Mar 28, 2024 •
edited
Loading

Fix the docs for computing the entanglement entropy, which has been misleading users, see for example https://itensor.discourse.group/t/entanglement-entropy-in-tdvp-calculation/1594.

Also update some code styles in the docs, library code, and examples, like change noprime!(a) to a = noprime(a), orthogonalize!(psi) to psi = orthogonalize(psi), etc.

@mtfishman
Copy link
Member Author

[test ITensorMPS]

@github-actions GitHub Actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/8468735929

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/8468735929

@mtfishman
Copy link
Member Author

[test ITensorMPS] [test ITensorGaussianMPS]

@mtfishman
Copy link
Member Author

[test ITensorTDVP]

@github-actions GitHub Actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470496282

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470496282

@github-actions GitHub Actions
Copy link
Contributor

Run ITensorTDVP tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470498730

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Run ITensorTDVP tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470498730

@github-actions GitHub Actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470496288

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/8470496288

@mtfishman mtfishman merged commit 7f8d21b into main Mar 28, 2024
12 checks passed
@mtfishman mtfishman deleted the ITensors_docs_fix branch March 28, 2024 17:05
@mtfishman mtfishman changed the title [Docs] Fix entanglement entropy calculation [Docs] Fix entanglement entropy example Mar 28, 2024
@emstoudenmire
Copy link
Collaborator

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtfishman @emstoudenmire