Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensorMPS] Observers package extension #1376

Closed
wants to merge 9 commits into from

Conversation

emstoudenmire
Copy link
Collaborator

This PR introduces a simple package extension that defines ITensorMPS.update_observer! when the Observers package is loaded, and a simple test for it. It has been locally tested against the ITensorTDVP package also.

src/ITensors.jl Outdated Show resolved Hide resolved
src/ITensors.jl Outdated Show resolved Hide resolved
test/ITensorsObserversExt/runtests.jl Outdated Show resolved Hide resolved
test/ITensorsObserversExt/runtests.jl Outdated Show resolved Hide resolved
emstoudenmire and others added 3 commits April 2, 2024 22:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emstoudenmire
Copy link
Collaborator Author

Also I could add the PackageExtensionCompat dependency, but since it is being added in #1373 I hesitated to do that.

@mtfishman
Copy link
Member

mtfishman commented Apr 3, 2024

Thanks. We should use PackageExtensionCompat instead of the if !isdefined(Base, :get_extension) ... pattern. I'll be merging #1373 soon but the order of operations doesn't matter there.

However, before making any more changes to ITensorsMPS I think we should get downstream tests of ITensorTDVP working (#1370 (comment)).

@emstoudenmire
Copy link
Collaborator Author

Agreed about getting the tests going before merging this.

Also if you have any guesses why the ITensors and NDTensors tests are failing here I'm a bit at a loss as to why.

@mtfishman
Copy link
Member

Not sure what's going on there, the configuration looks good to me.

@mtfishman
Copy link
Member

Should this be closed?

@emstoudenmire
Copy link
Collaborator Author

Yes I just closed it. I'll use it as a reference for another PR or maybe two smaller ones.

@emstoudenmire emstoudenmire deleted the observers_extension branch April 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants