-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITensorMPS] Observers package extension #1376
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Also I could add the |
Thanks. We should use However, before making any more changes to |
Agreed about getting the tests going before merging this. Also if you have any guesses why the ITensors and NDTensors tests are failing here I'm a bit at a loss as to why. |
Not sure what's going on there, the configuration looks good to me. |
Should this be closed? |
Yes I just closed it. I'll use it as a reference for another PR or maybe two smaller ones. |
This PR introduces a simple package extension that defines
ITensorMPS.update_observer!
when theObservers
package is loaded, and a simple test for it. It has been locally tested against theITensorTDVP
package also.