Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final version of 1.07.2 #73

Merged
merged 101 commits into from
Jan 16, 2025
Merged

Final version of 1.07.2 #73

merged 101 commits into from
Jan 16, 2025

Conversation

djb-rwth
Copy link
Collaborator

No description provided.

cho-m and others added 30 commits November 12, 2024 12:09
@cho-m @JanCBrammer
Fix macOS dylib file name
05d5cb7
@djb-rwth @JanCBrammer
Update README.md
9870ed0
@djb-rwth @JanCBrammer
Version 1.07.2
f401ed9
@djb-rwth @JanCBrammer
Version 1.07.2
c785ddb
@djb-rwth @JanCBrammer
Version 1.07.2
637d0cd
@djb-rwth @JanCBrammer
Version 1.07.2
6982653
@djb-rwth @JanCBrammer
Version 1.07.2
d2c008d
@djb-rwth @JanCBrammer
Version 1.07.2
39a848a
@djb-rwth @JanCBrammer
Version 1.07.2
4781cf2
@djb-rwth @JanCBrammer
Version 1.07.2
0bb4b76
@djb-rwth @JanCBrammer
Version 1.07.2
360a901
@djb-rwth @JanCBrammer
Version 1.07.2
bc25174
@djb-rwth @JanCBrammer
Version 1.07.2
a65a313
@djb-rwth @JanCBrammer
Version 1.07.2
80a3f4b
@djb-rwth @JanCBrammer
Version 1.07.2
f390584
@djb-rwth @JanCBrammer
Version 1.07.2
503496c
@djb-rwth @JanCBrammer
Version 1.07.2
70dc3f4
@djb-rwth @JanCBrammer
Version 1.07.2
d7a4c5a
@djb-rwth @JanCBrammer
Version 1.07.2
732fa49
@djb-rwth @JanCBrammer
Version 1.07.2
626e1ff
@djb-rwth @JanCBrammer
Version 1.07.2
700998b
@djb-rwth @JanCBrammer
Version 1.07.2
ac8bbf3
@djb-rwth @JanCBrammer
Version 1.07.2
10743d1
@djb-rwth @JanCBrammer
Update README.md
5269440
@JanCBrammer
Update .gitignore
b1381d3
@JanCBrammer
Normalize line endings according to .gitattributes
7507f2b
@JanCBrammer
Include INCHI_EXE in Docker container
4123ddd
@JanCBrammer
Make executable test-wrapper more generic
423cfa1
@JanCBrammer
Add test for issue #67
7357244
@djb-rwth
Version 1.07.2
3603b8f
JanCBrammer
JanCBrammer reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@JanCBrammer JanCBrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djb-rwth, looks good, I have a few minor comments.

INCHI-1-SRC/INCHI_API/demos/inchi_main/src/e_0dstereo.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_API/demos/inchi_main/src/e_ichi_parms.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_API/demos/test_ixa/src/test_ixa.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_BASE/src/ichiparm.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_BASE/src/ichiread.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_BASE/src/ichister.c Outdated Show resolved Hide resolved
INCHI-1-SRC/INCHI_BASE/src/strutil.c Outdated Show resolved Hide resolved
@djb-rwth
Copy link
Collaborator Author

@JanCBrammer -- thanks for this.
Back to work, and will push the changed files and all binaries ASAP.

@djb-rwth djb-rwth closed this Jan 14, 2025
@JanCBrammer
Copy link
Collaborator

@djb-rwth, re-opening this since pushing new changes will update this PR automatically 🙂

@JanCBrammer JanCBrammer reopened this Jan 14, 2025
@djb-rwth
Copy link
Collaborator Author

@JanCBrammer Sorry for that -- thanks!

@djb-rwth
Copy link
Collaborator Author

@JanCBrammer Revisions pushed.

@djb-rwth
Copy link
Collaborator Author

One more revision added.

JanCBrammer
JanCBrammer approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@JanCBrammer JanCBrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, I resolved them and, as far as I'm concerned, this PR is good to go 🚀

@JanCBrammer JanCBrammer merged commit c1435ac into main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanCBrammer JanCBrammer JanCBrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djb-rwth @JanCBrammer @cho-m