Custom import order separation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
custom-import-order-separation
branch
from
fc4db3c
to
2fe5b78
Compare
3 tasks
fbartho
approved these changes
May 16, 2022
| */ | ||
| export const adjustCommentsOnSortedNodes = ( | ||
| nodes: ImportDeclaration[], | ||
| finalNodes: ImportOrLine[], | ||
| ) => { | ||
| // maintain a copy of the nodes to extract comments from | ||
| // We will mutate a copy of the finalNodes, and extract comments from the original |
|
@blutorange I'm going to merge this, but let me know if you want any changes and I can make them in a follow-up. |
`getSortedNodesByImportOrder` includes a check for `importOrderSeparation`, and adds newlines when it's true, so we should include that in our tests.
But the last snapshot is wrong, will fix in next commit
Mutating the original nodes causes strange effects, as seen in the snapshot
IanVS
force-pushed
the
custom-import-order-separation
branch
from
2fe5b78
to
b601cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
This is an adaptation of trivago/prettier-plugin-sort-imports#42 from @atombrenner. I wasn't able to use most of the commits from the original branch, because our approach is different in this project, but I did pull in his commit with tests.
The other change I needed to make here was to modify the cloned nodes in
adjustCommentsOnSortedNodes, rather than mutating the original, which was leading to some strange bugs in the tests.