-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: node:test
not grouped with <BUILTIN_MODULES>
#143
Merged
IanVS
merged 6 commits into
IanVS:main
from
IsaiahByDayah:fix/node-test-not-grouped-with-builtin-modules
Jan 31, 2024
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dc9fc82
chore: outline groups-node-test-with-builtin-modules test
IsaiahByDayah 8f36812
fix: support node:test in BUILTIN_MODULES_REGEX_STR
IsaiahByDayah cceefc7
chore: additional test cases
IsaiahByDayah 6cf8026
chore: simplify regex
IsaiahByDayah 37af38f
chore: update comment for extra clarity
IsaiahByDayah 3170e52
fix: formatting
IsaiahByDayah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
tests/BuiltinModulesNodeTest/__snapshots__/ppsi.spec.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | ||
|
||
exports[`groups-node-test-with-builtin-modules.js - typescript-verify > groups-node-test-with-builtin-modules.js 1`] = ` | ||
import nodeUtil from 'node:util'; | ||
|
||
import nodeNodeTestTest from 'node:node:test:test'; | ||
import nodeNodeTest from 'node:node:test'; | ||
import nodeTestTest from 'node:test:test'; | ||
import nodeTest from 'node:test'; | ||
import test from 'test' | ||
import node from 'node'; | ||
|
||
import fs from 'fs'; | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
import fs from "fs"; | ||
import nodeTest from "node:test"; | ||
import nodeUtil from "node:util"; | ||
|
||
import node from "node"; | ||
import nodeNodeTest from "node:node:test"; | ||
import nodeNodeTestTest from "node:node:test:test"; | ||
import nodeTestTest from "node:test:test"; | ||
import test from "test"; | ||
|
||
`; |
10 changes: 10 additions & 0 deletions
10
tests/BuiltinModulesNodeTest/groups-node-test-with-builtin-modules.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import nodeUtil from 'node:util'; | ||
|
||
import nodeNodeTestTest from 'node:node:test:test'; | ||
import nodeNodeTest from 'node:node:test'; | ||
import nodeTestTest from 'node:test:test'; | ||
import nodeTest from 'node:test'; | ||
import test from 'test' | ||
import node from 'node'; | ||
|
||
import fs from 'fs'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import {run_spec} from '../../test-setup/run_spec'; | ||
|
||
run_spec(__dirname, ["typescript"], { | ||
importOrder: [ | ||
"", | ||
"<BUILTIN_MODULES>", | ||
"", | ||
"<THIRD_PARTY_MODULES>", | ||
"", | ||
"^[.]", | ||
], | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only small suggestion is to add a link to the issue: nodejs/node#42785. Maybe someday it will be solved, and we will be able to remove this workaround.