Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Ignore unknown option importOrderBuiltinModulesToTop" #15

Merged
merged 1 commit into from
May 17, 2022

Conversation

fbartho
Copy link
Collaborator

@fbartho fbartho commented May 17, 2022

I pulled release 3.4.0 and added the new rule, and unfortunately got these complaints from prettier:

[warn] Ignored unknown option { importOrderBuiltinModulesToTop: true }.

I compared other Config Options, and this is my guess at the necessary fix

I pulled release 3.4.0 and added the new rule, and unfortunately got these complaints from prettier:

```
[warn] Ignored unknown option { importOrderBuiltinModulesToTop: true }.
```

I compared other Config Options, and this is my guess at the necessary fix
@fbartho
Copy link
Collaborator Author

fbartho commented May 17, 2022

./cc @IanVS sorry I didn't find this before your release!

Copy link
Owner

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yeah good catch, thanks. Not sure how I missed this either. We might need to take a look at our tests, and maybe add some cli tests.

@IanVS IanVS merged commit cfeab05 into IanVS:main May 17, 2022
@fbartho fbartho deleted the fb/fix-builtins-option-spec branch May 17, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants