Maintenance: use fine-grained lodash-imports #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodash is a huge and chunky module. If we directly specify which methods we need from it, we can avoid a bit of the always-keep-it-up-to-date treadmill.
Further investigation could be done to see if we really even need the
clone
/isEqual
methods from lodash, but at least with this PR change we put a soft fence around it to keep from panicking if lodash has security incidents. And to keep it from spreading 😉.Not a big deal if you don't want to drop it, since the version of whatwg-url that is used by jsdom used by jest still needs it (even if newer versions don't), but I thought I'd provide a PR.
I'm aware that in lodash v5 they claim they will stop deploying the individual module packages, but that argument is based on "runtime package bundling" arguments, rather than on the maintenance concerns.