Avoid initial new line when using custom group separator #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbartho
approved these changes
May 30, 2022
There was a problem hiding this comment.
This feels like a good fix to me, I was noticing similar issues when I applied this to a large project. Thoughts @IanVS @blutorange?
IanVS
reviewed
May 31, 2022
| @@ -70,8 +70,13 @@ export const getSortedNodesByImportOrder: GetSortedNodes = (nodes, options) => { | |||
| for (const group of importOrder) { | |||
| // If it's a custom separator, all we need to do is add a newline | |||
| if (isCustomGroupSeparator(group)) { | |||
| const lastNode = finalNodes[finalNodes.length - 1]; | |||
| // Avoid empty new line if first group is empty | |||
| if (!lastNode) { | |||
There was a problem hiding this comment.
This feels a little bit indirect. Could we check if finalNodes.length === 0? Would that accomplish the same thing?
There was a problem hiding this comment.
It would be the same thing for this first checks, but then I would need to assert TS that the list is non empty for the next check (or add a useless runtime check)
|
Thanks for the contribution, @ArnaudBarre! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this screenshot will highlight what I feel like an inconsistency: