Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug report and feature templates #3

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

IanVS
Copy link
Owner

@IanVS IanVS commented Mar 17, 2022

I found that references to Trivago were still in a few places, and we're not using discussions here, so I tweaked the templates slightly.

@IanVS IanVS marked this pull request as ready for review March 17, 2022 13:01
@IanVS IanVS requested a review from blutorange March 17, 2022 13:01
Copy link
Collaborator

@blutorange blutorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't see any spelling mistakes. I did a quick grep on the repo, there's one more references to trivago in the package.json

https://github.com/IanVS/prettier-plugin-sort-imports/blob/documentation-updates/package.json#L32

I suppose we should keep that though, since this is a fork? But you might want to add yourself.

The CHANGELOG.md has some more references to issues over at https://github.com/trivago/prettier-plugin-sort-imports, but I guess that's fine too.

@IanVS IanVS merged commit b220533 into main Mar 17, 2022
@IanVS
Copy link
Owner Author

IanVS commented Mar 17, 2022

Thanks for the review.

But you might want to add yourself.

Yeah, I didn't add myself so far, because I haven't actually done any real contributing, I just set up the fork, lol. And, I do want to continue giving credit where it's due to the trivago folks, and keeping the history in the changelog seemed appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants