Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior around comments embedded in imports #71

Merged
merged 25 commits into from
May 12, 2023
Merged

Fix behavior around comments embedded in imports #71

merged 25 commits into from
May 12, 2023

Commits on May 11, 2023

  1. Add irritating test cases for comments around imports

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4b0fd09 View commit details
    Browse the repository at this point in the history

  2. Change test-cases so top-of-file comments have a gap (otherwise they … 

    …attach to the following import!)
    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    919b5da View commit details
    Browse the repository at this point in the history

  3. Initial types & constants for ImportComments Preservation

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0a96f12 View commit details
    Browse the repository at this point in the history

  4. Fix get-all-comments

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c516cf2 View commit details
    Browse the repository at this point in the history

  5. Change test-cases so top-of-file comments have a gap (more tests)

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b69eb21 View commit details
    Browse the repository at this point in the history

  6. Feature: Update Import-adjacent Comment Adjustment to handle all the … 

    …cases
    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    bda233c View commit details
    Browse the repository at this point in the history

  7. Remove a no-longer-needed dependency lodash.isequal

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0efd6c3 View commit details
    Browse the repository at this point in the history

  8. Formatting tweaks

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    18c3045 View commit details
    Browse the repository at this point in the history

  9. Minor test cleanup

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    cec6f65 View commit details
    Browse the repository at this point in the history

  10. lol forgot to format

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    743e16a View commit details
    Browse the repository at this point in the history

  11. Merge branch 'next' into fb/fix-import-comments

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2f300ef View commit details
    Browse the repository at this point in the history

  12. Update for new Babel, and remove workarounds

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8fcda28 View commit details
    Browse the repository at this point in the history

  13. Finish patch cleanup

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b6965f8 View commit details
    Browse the repository at this point in the history

  14. Unnecessary let

    @fbartho
    fbartho committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6eadf55 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Use node.loc.end.line instead of start.line in certain comparison… 

    …s (just in case)
    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ec11257 View commit details
    Browse the repository at this point in the history

  2. PR Feedback: only-same-line-comments should be treated as trailing 

    Fixes:
- trailing attachments should be used much more rarely / leading comment on code shouldn't treated as trailing comment on an import
- various unexpected newline injections
- unnecessary test3, is duplicate of test2
- some test cases now behave correctly, but had comments added implying things about gaps being unexpectedly deleted (when they're definitely present)
    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fca0377 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'next' into fb/fix-import-comments

    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    90bb398 View commit details
    Browse the repository at this point in the history

  4. Seeing CI-flaking? Disable the yarn-cache in-case that's it

    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2d54d8e View commit details
    Browse the repository at this point in the history

  5. Revert "Seeing CI-flaking? Disable the yarn-cache in-case that's it" 

    This reverts commit 2d54d8e.
    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8b22a8e View commit details
    Browse the repository at this point in the history

  6. Accidentally stashed this critical line!

    @fbartho
    fbartho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    aae640e View commit details
    Browse the repository at this point in the history

  7. Small test tweaks

    @IanVS
    IanVS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c68ca80 View commit details
    Browse the repository at this point in the history

  8. Rename id -> commentId for clarity

    @IanVS
    IanVS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    58c8d01 View commit details
    Browse the repository at this point in the history

  9. Clean up lastImport logic 

    I think this is no longer needed, now that we ignore trailing imports
on a following line.
    @IanVS
    IanVS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    375be16 View commit details
    Browse the repository at this point in the history

  10. Add test for multi-line comment block spanning lines

    @IanVS
    IanVS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cbf6839 View commit details
    Browse the repository at this point in the history

  11. Simplify readme just a tad

    @IanVS
    IanVS committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7bd1f5e View commit details
    Browse the repository at this point in the history