-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior Change: All comments before firstImport are treated as top-of-file #82
Commits on May 12, 2023
-
Preserve trailing comments on specifiers (they don't get automaticall…
…y saved like top-level ones do) Fixes #79
Configuration menu - View commit details
-
Copy full SHA for ee0bdd0 - Browse repository at this point
Copy the full SHA ee0bdd0View commit details
Commits on May 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1ab1031 - Browse repository at this point
Copy the full SHA 1ab1031View commit details -
Configuration menu - View commit details
-
Copy full SHA for e020081 - Browse repository at this point
Copy the full SHA e020081View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e2ff94 - Browse repository at this point
Copy the full SHA 1e2ff94View commit details
Commits on May 15, 2023
-
Preserve trailing comments on specifiers (#80)
Fixes #79 Trailing comments on specifiers don't get automatically saved like top-level ones do. This ensures that such comments are not lost Before: ```ts import { b2,a2, // @ts-expect-error } from "b"; import { b1, a1, // @ts-expect-error } from "a"; ``` After ```ts import { a1, b1, // @ts-expect-error } from "a"; import { a2, b2, // @ts-expect-error } from "b"; ``` --------- Co-authored-by: Ian VanSchooten <ian.vanschooten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dbf31ee - Browse repository at this point
Copy the full SHA dbf31eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bb7086 - Browse repository at this point
Copy the full SHA 0bb7086View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a00f2 - Browse repository at this point
Copy the full SHA 20a00f2View commit details -
Handle type + value importing better
This treats the first node as the "winner", so that our "currentOwnerIsFirstImport" logic works correctly for comments at top of files
Configuration menu - View commit details
-
Copy full SHA for 73eec7b - Browse repository at this point
Copy the full SHA 73eec7bView commit details -
Merge remote-tracking branch 'origin/next' into fb/protect-the-top-of…
…-file # Conflicts: # src/utils/get-comment-registry.ts
Configuration menu - View commit details
-
Copy full SHA for 5d71054 - Browse repository at this point
Copy the full SHA 5d71054View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd07d70 - Browse repository at this point
Copy the full SHA bd07d70View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddea041 - Browse repository at this point
Copy the full SHA ddea041View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9f69fb - Browse repository at this point
Copy the full SHA d9f69fbView commit details
Commits on May 16, 2023
-
Slight reorganization around top-of-file comments (#84)
I think this makes the code a little easier to follow. I wasn't able to add an end-to-end integration test around "empty-statements-at-top-of-file" because you're right @IanVS, other layers prevent that from happening. Instead I added a unit-test to assert the fatal-errors that we throw.
Configuration menu - View commit details
-
Copy full SHA for e9a9950 - Browse repository at this point
Copy the full SHA e9a9950View commit details