Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting jekyll 4. #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Supporting jekyll 4. #8

wants to merge 8 commits into from

Conversation

b00f
Copy link

@b00f b00f commented Jan 22, 2022

Supporting Rust 2018 and Jeykyll 4.

@IanWhitney
Copy link
Owner

Closes #1

Copy link
Owner

@IanWhitney IanWhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍with this. Thanks for the work. I only have the one question about minimum Jekyll version. Jekyll 2.x hasn't been updated in 7 years, so maybe we switch to supporting 3.x through 4.1

@@ -17,5 +17,5 @@ Gem::Specification.new do |gem|
gem.require_paths = ["lib"]
gem.license = "MIT"

gem.add_dependency "jekyll", ">= 2.0", "< 4.0"
gem.add_dependency "jekyll", ">= 2.0", "<= 4.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work under Jekyll 2? Or should this bump the minimum Jekyll version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I updated the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants