-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting jekyll 4. #8
base: master
Are you sure you want to change the base?
Conversation
Closes #1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍with this. Thanks for the work. I only have the one question about minimum Jekyll version. Jekyll 2.x hasn't been updated in 7 years, so maybe we switch to supporting 3.x through 4.1
rust_playground_highlight.gemspec
Outdated
@@ -17,5 +17,5 @@ Gem::Specification.new do |gem| | |||
gem.require_paths = ["lib"] | |||
gem.license = "MIT" | |||
|
|||
gem.add_dependency "jekyll", ">= 2.0", "< 4.0" | |||
gem.add_dependency "jekyll", ">= 2.0", "<= 4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still work under Jekyll 2? Or should this bump the minimum Jekyll version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I updated the code
Supporting Rust 2018 and Jeykyll 4.