Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance reminders system #265

Merged
merged 14 commits into from
Jun 18, 2023
Merged

Enhance reminders system #265

merged 14 commits into from
Jun 18, 2023

Conversation

Infernum1
Copy link
Contributor

@Infernum1 Infernum1 commented May 27, 2023 •
edited
Loading

  • Group all reminder commands under one parent command
  • Add a reminder delete command
  • Add translations for the required texts

Has been tested and should be working smoothly

Iapetus-11
Iapetus-11 requested changes May 28, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I'll look over it again later but good job

bot/cogs/commands/useful.py Outdated Show resolved Hide resolved
bot/cogs/commands/useful.py Outdated Show resolved Hide resolved
bot/cogs/commands/useful.py Outdated Show resolved Hide resolved
@Infernum1 @Iapetus-11
add aliases to reminder_delete
10a8ee0 
Co-authored-by: Milo Weinberg <38477514+Iapetus-11@users.noreply.github.com>
Iapetus-11
Iapetus-11 requested changes May 29, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you modify the name of a command, iirc you need to update the help text entry in the translation files. Could you do that? I'll pull this branch after and we can test it.

@Iapetus-11 Iapetus-11 added the enhancement New feature or request label May 31, 2023
Iapetus-11
Iapetus-11 requested changes Jun 4, 2023
View reviewed changes
bot/data/text/en.json Show resolved Hide resolved
Iapetus-11
Iapetus-11 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll test and merge later today or tomorrow.

@Infernum1 Infernum1 closed this Jun 6, 2023
@Infernum1 Infernum1 deleted the reminder-enhance branch June 6, 2023 13:30
@Infernum1 Infernum1 restored the reminder-enhance branch June 6, 2023 13:33
@Infernum1 Infernum1 reopened this Jun 6, 2023
Iapetus-11
Iapetus-11 requested changes Jun 6, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the translations, <duration> and <text> need to be translated. I would suggest giving the entire line to translators, as context matters.

Iapetus-11
Iapetus-11 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm I'll deploy it to the test bot so we can test

@Infernum1
Copy link
Contributor Author

Alright cool cool

Iapetus-11
Iapetus-11 requested changes Jun 17, 2023
View reviewed changes
Copy link
Owner

@Iapetus-11 Iapetus-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Infernum1
Copy link
Contributor Author

image

I see, will fix

@Iapetus-11 Iapetus-11 merged commit 18b4d44 into Iapetus-11:main Jun 18, 2023
1 check passed
@Iapetus-11
Copy link
Owner

Closes #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iapetus-11 Iapetus-11 Iapetus-11 approved these changes

Assignees

@Iapetus-11 Iapetus-11

@Infernum1 Infernum1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Infernum1 @Iapetus-11