Plugin errors when creating a new ticket

[lukeburden]

Hiya @physik932,

I don't know what your plans are with this plugin, but I have some improvements that could be great if you find the time.

This issue is for a breakage that happens when creating a new ticket - it'd be great to have absence of a ticket not cause breakage.

Prerequisites

Please answer the following questions for yourself before submitting an issue.

• I am running the latest version (1.0.0)
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed

Expected Behavior

When creating a new ticket in Zendesk (/agent/tickets/new/1) the plugin should ideally not explode. There is no ticket to be injected into the context, so the links cannot really be generated, but at present it displays an error which is not ideal.

Current Behavior

The plugin displays an error due to the absence of a ticket. The error:

The console output:

Steps to Reproduce

1. Configure the app with a URL that requires the presence of a ticket
2. Click on "New ticket" tab

Context

Please provide any relevant information about your setup.

• Browser Version:
• Operating System:

Failure Logs (Follow steps to reproduce with Developer Tools open - Usually F12)

vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 Deferring customer analytics integration.
vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 Checking customer analytics integration (1)
vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 Enabling customer analytics integration.
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
A cookie associated with a cross-site resource at was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at and .
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 conversations is an unsupported, undocumented API. Use comments instead.
t. @ vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34
vendors~web_widget.6ea2f52fc2e51de1e202.chunk.js:149 Our embeddable contains third-party, open source software and/or libraries. To view them and their license terms, go to http://goto.zendesk.com/embeddable-legal-notices
/api/v2/zero_states-64e395e55494bfa00c61fc9756d3ff97.json?section=views:1 Failed to load resource: the server responded with a status of 404 ()
vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 conversations is an unsupported, undocumented API. Use comments instead.
t. @ vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34
/api/v2/tickets/undefined.json:1 Failed to load resource: the server responded with a status of 400 ()
cai.min.js:1 Enabling customer analytics integration.
cai.min.js:1 Enabling customer analytics integration.
onloadwff.js:71 Uncaught TypeError: Cannot read property 'toUpperCase' of undefined
at should_fill_on_click (onloadwff.js:71)
at onloadwff.js:71
vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34 conversations is an unsupported, undocumented API. Use comments instead.
t. @ vendor-9fb6a2b10cbc0d930affec16a7c4a320.js:34
/api/v2/tickets/undefined.json:1 Failed to load resource: the server responded with a status of 400 ()
app.js:1 ObjectreadyState: 4responseJSON: {error: {…}}responseText: "{↵ "error": {↵ "title": "Invalid attribute",↵ "message": "You passed an invalid value for the id attribute. Invalid parameter: id must be an integer"↵ }↵}↵"status: 400statusText: "error"proto: Object
m @ app.js:1
app.js:1 ReferenceError: ticket is not defined
at eval (eval at (lodash@4.3.0,handlebarsjs@4.0.5,jquery@2.2.0:102), :3:129)
at app.js:1
at a (lodash@4.3.0,handlebarsjs@4.0.5,jquery@2.2.0:8)
at Function.re [as map] (lodash@4.3.0,handlebarsjs@4.0.5,jquery@2.2.0:51)
at A (app.js:1)
at b (app.js:1)
at t. (app.js:1)
at f (app.js:1)
at Generator._invoke (app.js:1)
at Generator.S.forEach.t. [as next] (app.js:1)
m @ app.js:1
app.js:1 Uncaught (in promise) TypeError: Cannot read property 'reduce' of undefined
at app.js:1
at t.value (app.js:1)
at t. (app.js:1)
at f (app.js:1)
at Generator._invoke (app.js:1)
at Generator.S.forEach.t. [as next] (app.js:1)
at r (app.js:1)
at c (app.js:1)
DevTools failed to parse SourceMap: chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/sourcemaps/onloadwff.js.map
DevTools failed to parse SourceMap: chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/sourcemaps/onloadwff.js.map
DevTools failed to parse SourceMap: chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/sourcemaps/onloadwff.js.map
DevTools failed to parse SourceMap: chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/sourcemaps/onloadwff.js.map
DevTools failed to parse SourceMap: chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/sourcemaps/onloadwff.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/application-1475bd49771af17088b8d9300e970770.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/vendor-a4d4b467b7a758fced1121b8186ba15a.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/app.8d10f9e9b0c4457fe.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/chariot-c107ce936d3ce83b405e828c2207ac01.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/vendor.84a7fde118354ff04.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/runtime.85854b9f0bd78b7e9.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/help_widget-0a432468c0ac1c09f28a0485d7e4b14d.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/voice-dd7624b0e039f51f851a67f0004027e4.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/40.802c5d49f5ba56246.chunk.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/admin-d0b92f0faf6360b2f1c214ed9cc065f3.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/27.885ae41e15de485a0.chunk.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/26.833b51289f8b30c59.chunk.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/app_framework-cf946bfabb2d7f6d4eefb61ac8dc5d28.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/plan_selection-00572f10a1ee9b18bedb90b079e309a0.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/async.commons.8cc31ab2f85f3a798.chunk.js.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/filters-097ec5500a1ebc5296024638f65a1eeb.map
DevTools failed to parse SourceMap: https://static.zdassets.com/agent/assets/react/js/35.8186782351358c46f.chunk.js.map

[jloibl]

@physik932 thanks for building this app mate, greatly appreciated! Just wanted to let you know I am experiencing the same issue as Luke with using the app on new tickets.

Cheers

[1951FDG]

Since new ticket has no ticket.id, I removed the new_ticket_sidebar entry in manifest.json

[physik932]

Hey y'all, sorry for coming back to this so late. I had forked this from the original repo where the location was set for new_ticket_sidebar. I believe @1951FDG is correct that since there is no ticket context to inject, the app will just error out in its current state.

I think removing new_ticket_sidebar from manifest.json will be the fix going forward unless a direct need to have links in the new_ticket_sidebar and a PR is put up.