Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app from new ticket sidebar, update docs, cut a release #37

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Remove app from new ticket sidebar, update docs, cut a release #37

merged 4 commits into from
Apr 28, 2023

Conversation

physik932
Copy link
Collaborator

@physik932 physik932 commented Apr 27, 2023 •
edited
Loading

Fixes #21

  • Currently the app errors when a new ticket is created as it doesn't have ticket context to inject. This is not ideal since we know ticket context is unavailable during new ticket creation. This PR removes adding the app to the new ticket sidebar.

Fixes #22

  • I've updated docs and plan to upload the packaged app as part of a new release. In addition, I've added more detailed instructions to build the app from source to upload.

@physik932 physik932 added the enhancement New feature or request label Apr 27, 2023
@physik932 physik932 self-assigned this Apr 27, 2023
@physik932 physik932 changed the title Remove app from new ticket sidebar Remove app from new ticket sidebar, update docs, cut a release Apr 27, 2023
@physik932 physik932 mentioned this pull request Apr 27, 2023
Closed
@physik932 physik932 merged commit 763fc4a into main Apr 28, 2023
@physik932 physik932 deleted the physik932/fix-new-ticket-error branch April 28, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr3cj kr3cj kr3cj approved these changes

@onyxraven onyxraven onyxraven approved these changes

Assignees

@physik932 physik932

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private App Upload Error Plugin errors when creating a new ticket
3 participants
@physik932 @onyxraven @kr3cj