Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance updates #35

Merged
merged 60 commits into from
Apr 24, 2023
Merged

maintenance updates #35

merged 60 commits into from
Apr 24, 2023

Conversation

physik932
Copy link
Collaborator

@physik932 physik932 commented Apr 20, 2023

Description

Starting some maintenance again! I used zcli to generate an app with Node 18, and moved pieces of the app over til it worked and tests passed. I removed a bunch of react stuff from as it wasn't used. I think for the most part, everything is working as it used to.

TODO

  • Switch to GHA (Ibotta deprecated use of Travis)
  • Update documentation, templates
  • Update dependencies around webpack
  • Remove unused dependencies

@physik932 physik932 changed the title got something rendering at least maintenance updates Apr 20, 2023
@physik932 physik932 self-assigned this Apr 20, 2023
@physik932 physik932 added the work in progress When the feature is in progress label Apr 20, 2023
@physik932 physik932 marked this pull request as ready for review April 20, 2023 20:58
Comment on lines +2 to +7
"presets": [
["@babel/preset-env", {
"useBuiltIns": "usage",
"corejs": 3
}
]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From babel:

As of Babel 7.4.0, this package has been deprecated in favor of directly including core-js/stable (to polyfill ECMAScript features

testEnvironmentOptions: {
url: 'http://localhost/'
},
testEnvironment: 'jsdom',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this post:

The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.

Consider using the "jsdom" test environment.

Comment on lines +9 to 19
const config = {
plugins: [
postCssImport,
postcssAdvancedVariables(),
postcssAtroot(),
postcssExtendRule(),
postcssNested(),
postcssPresetEnv(),
postcssPropertyLookup(),
]
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precss is no longer maintained. From this issue comment, I was able to re-create the functionality.

Comment on lines -1 to -2
global._ = require('lodash');
global.faker = require('faker');
Copy link
Collaborator Author

@physik932 physik932 Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to import these into the files that were using them instead of globally. I was getting a global undefined error at some point

Comment on lines +10 to +11
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the node ECMAscript docs

These CommonJS variables are not available in ES modules.

__filename and __dirname use cases can be replicated via import.meta.url.

@physik932
Copy link
Collaborator Author

Some later TODOs:

  • rename default branch to main
  • probably get a better issue and feature template process in place
  • discussing usage of code climate, upload process to Ibotta's Zendesk domain for our personal usage

.nvmrc Outdated Show resolved Hide resolved
spec/app.spec.js Outdated Show resolved Hide resolved
@physik932 physik932 merged commit aca84da into master Apr 24, 2023
@physik932 physik932 deleted the physik932/updates-after-a-while branch April 24, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request review me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants