Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement logic for getting image architecture from scratch, instead of relying on google/go-containerregistry/crane. #42

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

tigerinus
Copy link
Contributor

Signed-off-by: Tiger Wang tigerwang@outlook.com

Signed-off-by: Tiger Wang <tigerwang@outlook.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #42 (b5122be) into main (d350877) will increase coverage by 3.32%.
The diff coverage is 57.60%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   45.06%   48.39%   +3.32%     
==========================================
  Files          18       18              
  Lines        1014     1058      +44     
==========================================
+ Hits          457      512      +55     
+ Misses        476      452      -24     
- Partials       81       94      +13     
Impacted Files Coverage Δ
pkg/docker/image.go 11.53% <0.00%> (-0.97%) ⬇️
pkg/docker/manifest.go 57.50% <ø> (+3.50%) ⬆️
pkg/docker/digest.go 56.25% <60.91%> (-6.58%) ⬇️
pkg/docker/auth.go 60.46% <0.00%> (+1.55%) ⬆️
pkg/docker/registry.go 45.45% <0.00%> (+45.45%) ⬆️
pkg/docker/trust.go 52.72% <0.00%> (+52.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tigerinus tigerinus merged commit eac3241 into main Feb 10, 2023
@tigerinus tigerinus deleted the replace_manifest_logic branch February 10, 2023 19:09
@tigerinus
Copy link
Contributor Author

This is needed due to google/go-containerregistry#377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant