Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roles tasks and vars SLES #158

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

dh-roland
Copy link
Contributor

For issue: #157
Add Role Tasks and vars for SUSE

@cla-bot
Copy link

cla-bot bot commented May 24, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @dh-roland

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@dh-roland
Copy link
Contributor Author

Recheck

@martialblog martialblog requested a review from mkayontour May 24, 2023 13:09
@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label May 24, 2023
@martialblog
Copy link
Member

Thanks for the PR! We will have a look at it 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a blank line between the tasks, it looks a bit cleaner and supports the readability.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional can you please use the Ansible FQCN notation for the zypper modules. https://docs.ansible.com/ansible/latest/collections/community/general/zypper_module.html

Copy link
Member

@mkayontour mkayontour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, eveything looks great so far. Two changes should be made, firstly the cosmetics in the install.yml. And secondly please add a changelog fragment.

Just create a yaml file in the changelog/fragments folder. Naming scheme should be something like feature_things_change_at_installation.yml and the content is similar to the following file: https://github.com/Icinga/ansible-collection-icinga/blob/main/changelogs/fragments/feature_monitoring_plugins.yml

Other than that, I'm happy to merge your PR

- changes for better reading
@dh-roland
Copy link
Contributor Author

@mkayontour Can you please check again :)

@mkayontour mkayontour self-assigned this May 31, 2023
@mkayontour mkayontour merged commit 16acfe8 into Icinga:main May 31, 2023
@mkayontour
Copy link
Member

I merged the PR, thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants