Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct version number into examples #94

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

l00ptr
Copy link
Contributor

@l00ptr l00ptr commented May 27, 2022

We replace v0.1.0 (this tag does not exist on github) by 0.1.0 into the collection usage examples.

We replace v0.1.0 (this tag does not exist on github) by 0.1.0 into the
collection usage examples.
@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Julian Vanden Broeck.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

We use the full name into the example
@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Julian Vanden Broeck.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@lbetz
Copy link
Member

lbetz commented May 27, 2022

Wrong is the tag, the leading v is used in examples and also in the Roadmap.

@l00ptr
Copy link
Contributor Author

l00ptr commented May 28, 2022

@lbetz So you are not using the "Semantic Versioning 2.0.0"; do you want to publish your repository thourgh Ansible Galaxy, otherwise v0.1.0 is not a valid version number - only version numbers using semver are imported there (https://galaxy.ansible.com/docs/contributing/version.html)

@mkayontour mkayontour merged commit b45330e into Icinga:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants